-
Notifications
You must be signed in to change notification settings - Fork 39
Removed Quickfacts & PSA's .sla and PDF's files, left only .md files #86
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lh1008 you approved all the recent merged PRs, which all deleted the .sla file. You also approved most of the the PRs that were breaking the markdown format. Please pay more attention when reviewing.
Anyway, i don't really see the point in adding the .sla file now. All other files in that format have been deleted and the .md are ready to be translated. I don't think the .sla files should be readded, it would just create confusion
I just noticed that the .sla files were deleted. To err is of humans, forgive my mistake. In #77 I posted those files were going to be deleted after we finish all the rest of the .md files and @BlackLotus64, not sure why, he deleted those files, and he is also a human, and is ok to have mistakes, I will be speaking with him also. I will be removing the rest of the .sla files. Thank you for the notice. |
Hey @erciccione, I removed all the .sla files and PDF's. I'm currently working on the final design edits for the PDF's so we can add them to the repository. Now we can work on a clean repo and with a smaller size :). The only folder that has all the documents and I left them intact is the Added new instructions on the README files also. Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are the images and .ttf files meant do be deleted?
4. Посетите онлайн форумы и выясните различные способы безопасного и защищенного хранения приватных ключей и мнемонической фразы, затем выберите тот способ, который лучше всего подходит для вас. Начать стоит здесь: https://www.getmonero.org/ru/community/hangouts/. Уже заметили, что исследования это большая тема? | ||
|
||
5. Следуйте другим лучшим практикам таким, как: никогда никому не показывайте ваши приватные ключи, используйте обменники только с хорошей репутацией, обновляйте ваш кошелек (кошельки) после каждого обновления/hard fork, никогда никому не говорите сколько у Вас XMR и всегда стремитесь изучить как можно больше! | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the following newlines are not necessary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done :)
Yeah, all the images are going to be removed and the PDF's are those left in each folder so anyone can download. That way we reduce the repo size to the minimum. |
Hi @erciccione,
Adding the 'zh' and 'ru' folders that were missing the .md files.
In the 'zh' folders added the giant_zh_.md files and also changed the folder to /storyboard. Noticed that in the #85 PR I approved it and did not notice the .sla and pdf's files were removed and those files are not ment to be removed yet, so I'm adding the files again for anyone who is still looking at the files.
Thank you guys :)