Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Python 3.6 #201

Closed
wants to merge 4 commits into from
Closed

Conversation

mattwthompson
Copy link
Member

Python 3.6 has been around for a while - and even Python 3.7 isn't too new - so we should start trying to support it.

This will probably require mosdef-hub/mbuild#457 and mosdef-hub/mbuild#435 to be merged first and then an mbuild release.

I am temporarily getting around plyplus issues (#172) by hosting builds on my own Anaconda channel; I will move those to the mosdef channel if it becomes necessary.

@mattwthompson mattwthompson added waiting for mbuild release WIP Work in Progress, not ready for merging labels Jan 5, 2019
@mikemhenry
Copy link
Member

Anything blocking this PR?

@mattwthompson
Copy link
Member Author

Yeah, we need to add each package to Anaconda but we can't do one before doing the other. And host plyplus on the official channel. A shotgun approach of just releasing them separately and hoping their tests pass might work, but that risks putting out builds that don't pass their own tests.

@mikemhenry
Copy link
Member

Adding the deps needed to a mosdef channel is the right thing to do, you could even added the noarch flag so this doesn't keep happening (or just bump the python version if you don't want to change anything).

I know hosting these isn't ideal, but many of these seem to be pure python packages that install just fine with pip, is there a way to tell conda to use pip to install them? Right now its really hard to use mBuild and foyer in new projects that I have going that are in python3.6

@mattwthompson
Copy link
Member Author

Closed #204

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting for mbuild release WIP Work in Progress, not ready for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants