Python 3.6 Support #204
Python 3.6 Support #204
Conversation
|
Okay so I forgot to include an |
|
Okay so travis is happy now and things don't get downgraded, I'm a bit grumpy that we will need to have 2 CI scripts to maintain and keep in sync, but |
|
I'm gonna mention this PR, since we're doing similar things to what we did in mbuild previously (I actually think we intended to do it for both but simply neglected to do it here) |
|
It would be nice to get parity between mbuild and foyer, I think for this I just want to remove the cyclic dependency stuff + not get python downgraded, so then we can do things how its working in mbuild. |
|
You're exactly right - the problem is that more needs to be done (see all the changes in the linked PR). I will take it upon myself to make those changes, since we need to release mbuild and we can't do so until similar changes have been made here. |
|
Added more python versions to travis so we can see what deps are going to be an issue for python 3.6 and 3.7 |
Lets see if this still works without cme-lab
.travis.yml
Outdated
| @@ -24,7 +24,6 @@ install: | |||
| - conda config --add channels omnia | |||
| - conda config --add channels conda-forge | |||
| - conda config --add channels mosdef | |||
| - conda config --add channels cmelab | |||
There was a problem hiding this comment.
Is all of omnia's work on conda-forge now?
There was a problem hiding this comment.
I don't think so: https://anaconda.org/search?q=openmm
(OpenMM is our only omnia dep, right?)
There was a problem hiding this comment.
AFAIK, yes just openmm, http://docs.openmm.org/latest/userguide/application.html#installing-openmm currently they haven't migrated all over to conda-forge, so you need omnia and conda-forge
|
Still waiting on OSX & windows tests, but it looks like all passes test for python3.6, also added |
appveyor.yml
Outdated
|
|
||
| build: false | ||
|
|
||
| test_script: | ||
| - "%CMD_IN_ENV% activate base" |
There was a problem hiding this comment.
Any reason why you removed this? I don't recall the specifics but I had to add this at one point to un-break something #195
|
Since I have the memory of a cinderblock, I'm going to note the things we want to spin off into other small PRs:
|
|
Okay things are split out now into separate PRs |
|
Use this link check appveyor https://ci.appveyor.com/project/mikemhenry/foyer/builds/22987938 The python 2.7 fail looks like it can't find a foyer 2.7 build, not sure why it needs that, this is fixed in a later PR where it runs tests using pytest without invoking the conda-build process which is unnecessary |
|
3.5 and 3.6 appveyor passed |
|
Strange that Python 2.7 failed but I'm not inclined to investigate it much @justinGilmer we should sit down with Mike to get you up to speed on the many CI issues we've found but the short of this PR is that we can now reasonably expect to ship Python 3.6 |
|
@mattwthompson This one should be good to go, for the record, we never tested windows python2.7... |
No description provided.