Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Editor] Add a new dialog for the signature editor (bug 1945574) #19414

Merged
merged 1 commit into from
Feb 6, 2025
Merged

[Editor] Add a new dialog for the signature editor (bug 1945574) #19414

merged 1 commit into from
Feb 6, 2025

Conversation

calixteman
Copy link
Contributor

No description provided.

@calixteman calixteman requested a review from a team as a code owner February 3, 2025 17:38
@calixteman calixteman force-pushed the signature_dialog2 branch 2 times, most recently from bfa83c0 to 1a22a41 Compare February 3, 2025 17:42
flodolo
flodolo requested changes Feb 3, 2025
View reviewed changes
flodolo
flodolo approved these changes Feb 3, 2025
View reviewed changes
@Snuffleupagus Snuffleupagus self-requested a review February 3, 2025 21:15
@flodolo flodolo mentioned this pull request Feb 5, 2025
Merged
Snuffleupagus
Snuffleupagus reviewed Feb 5, 2025
View reviewed changes
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving a couple of initial comments/questions, however I've not yet reviewed the web/signature_manager.js file.

@Snuffleupagus Snuffleupagus self-requested a review February 5, 2025 19:34
Snuffleupagus
Snuffleupagus reviewed Feb 5, 2025
View reviewed changes
Snuffleupagus
Snuffleupagus approved these changes Feb 5, 2025
View reviewed changes
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the size of the patch any sort of detailed review isn't really feasible (at least not in a reasonable amount of time), but considering that this new feature/UI is limited to a particular Editor any problems here shouldn't really affect the rest of the viewer.

r=me, thank you.

@calixteman
Copy link
Contributor Author

Given the size of the patch any sort of detailed review isn't really feasible (at least not in a reasonable amount of time), but considering that this new feature/UI is limited to a particular Editor any problems here shouldn't really affect the rest of the viewer.

r=me, thank you.

Thank you for your review.
Your point is fair, but QA will test the new feature and likely find some bugs, and I'll write some integration tests asap.
In any case we'll have some other opportunities to make this code better.

@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/89076f934e19ae0/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/46c7baa9e48c0cc/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/89076f934e19ae0/output.txt

Total script time: 11.63 mins

  • Integration Tests: FAILED

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/46c7baa9e48c0cc/output.txt

Total script time: 26.36 mins

  • Integration Tests: FAILED

@calixteman calixteman merged commit 08663f7 into mozilla:master Feb 6, 2025
10 checks passed
@calixteman calixteman deleted the signature_dialog2 branch February 6, 2025 15:20
flodolo
flodolo reviewed Feb 7, 2025
View reviewed changes
l10n/en-US/viewer.ftl
pdfjs-editor-add-signature-image-placeholder = Drag a file here to upload
pdfjs-editor-add-signature-image-browse-link =
{ PLATFORM() ->
[macos] Or choose image files
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@calixteman
Question that came to me while translating. Is plural (files) correct here? Shouldn't it be singular (can only select one file)?

P.S. In case this needs to be updated, it will require a new ID at this point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flodolo flodolo flodolo approved these changes

@Snuffleupagus Snuffleupagus Snuffleupagus approved these changes

Assignees
No one assigned
Labels
editor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@calixteman @moz-tools-bot @Snuffleupagus @flodolo