Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Editor] Add the possibility to compress/decompress the signature data in order to store them in the logins storage in Firefox (bug 1946171) #19425

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

calixteman
Copy link
Contributor

No description provided.

@calixteman calixteman requested a review from a team as a code owner February 5, 2025 18:35
@calixteman calixteman removed the request for review from a team February 5, 2025 18:36
@flodolo
Copy link
Contributor

flodolo commented Feb 5, 2025

What's the difference between this and #19414 (string-wise)?

@calixteman
Copy link
Contributor Author

What's the difference between this and #19414 (string-wise)?

No difference. It's just because this patch has been created on top of the other branch.

@calixteman calixteman force-pushed the signature_save branch 2 times, most recently from 52479ee to 6224bbc Compare February 10, 2025 15:49
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, thank you.

…r to store them in the logins storage in Firefox (bug 1946171)
@calixteman
Copy link
Contributor Author

/botio unittest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_unittest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/71fc33aec33bb78/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_unittest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/0214a59f76c22df/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/71fc33aec33bb78/output.txt

Total script time: 2.35 mins

  • Unit Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Success

Full output at http://54.193.163.58:8877/0214a59f76c22df/output.txt

Total script time: 8.46 mins

  • Unit Tests: Passed

@calixteman calixteman merged commit e3cca6d into mozilla:master Feb 10, 2025
9 checks passed
@calixteman calixteman deleted the signature_save branch February 10, 2025 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants