-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs][material-nextjs] Add theming and configuration content to the page #40626
Conversation
Netlify deploy previewBundle size report |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job on this!
@@ -47,6 +47,88 @@ Inside `app/layout.tsx`, import the `AppRouterCacheProvider` and wrap all elemen | |||
} | |||
``` | |||
|
|||
### Custom cache |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the reason or benefit of doing this? (Why would a user take this step?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see 2 cases:
- They have their own
stylisPlugins
that they want to use, e.g. emotion has a bug with:where
selector, using a customstylisPlugins
is a workaround that we are doing in our doc. - They want to change the default CSS key (
mui
) to something else.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it—I think we could explain this here, and maybe mention that it's not required. I could see this being confusing if you don't know whether or not you need to do this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@samuelsycamore I move it under h4 as a content of Configuration and with optional at the end ### Custom cache (optional)
.
What do you think?
Co-authored-by: Sam Sycamore <[email protected]> Signed-off-by: Siriwat K <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢 it!
Closes #40238
https://deploy-preview-40626--material-ui.netlify.app/material-ui/guides/nextjs/#configuration-2