Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[material-ui][docs] Fix createTheme import and markdown format in the Next.js guide #40895

Merged
merged 5 commits into from
Feb 3, 2024

Conversation

hsmtkk
Copy link
Contributor

@hsmtkk hsmtkk commented Feb 2, 2024

Because the function createTheme is imported twice, it causes IDE to issue warnings.
I deleted the first one.

Preview: https://deploy-preview-40895--material-ui.netlify.app/material-ui/guides/nextjs/

A polish on #40626.

@mui-bot
Copy link

mui-bot commented Feb 2, 2024

Netlify deploy preview

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against d27fddc

@danilo-leal danilo-leal changed the title createTheme is imported twice [material-ui][docs] createTheme is imported twice in the Next.js guide Feb 2, 2024
@danilo-leal danilo-leal added docs Improvements or additions to the documentation package: material-ui Specific to @mui/material nextjs labels Feb 2, 2024
Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thank you for opening this PR & your first contribution here! 🤙

@oliviertassinari oliviertassinari added the bug 🐛 Something doesn't work label Feb 3, 2024
@oliviertassinari oliviertassinari changed the title [material-ui][docs] createTheme is imported twice in the Next.js guide [material-ui][docs] Fix createTheme import and markdown format in the Next.js guide Feb 3, 2024
@oliviertassinari oliviertassinari merged commit 8d9b376 into mui:master Feb 3, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work docs Improvements or additions to the documentation nextjs package: material-ui Specific to @mui/material
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants