Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request confirmation faster for new blocks #1518

Merged
merged 31 commits into from
Feb 5, 2019

Conversation

SergiySW
Copy link
Contributor

No description provided.

@SergiySW SergiySW self-assigned this Dec 30, 2018
@zhyatt zhyatt added this to the V18.0 milestone Jan 2, 2019
@zhyatt
Copy link
Collaborator

zhyatt commented Jan 16, 2019

Plan to test performance once #1133 is available

Copy link
Contributor

@cryptocode cryptocode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SergiySW
Copy link
Contributor Author

Should be rebased after #1657

@zhyatt zhyatt added the functionality quality improvements This item indicates the need for or supplies a better way to implement existing functionality label Jan 30, 2019
@SergiySW SergiySW changed the title Broadcast new blocks & request confirmation faster Request confirmation faster for new blocks Jan 30, 2019
@argakiig argakiig merged commit 37d9720 into nanocurrency:master Feb 5, 2019
argakiig pushed a commit that referenced this pull request Feb 5, 2019
* Broadcast new blocks & request confirmation faster

* Limit max broadcast_confirm_req

* Minimum broadcast of 2 * sqrt or 100 peers

* Disable fast broadcast with large broadcast queue

* Use std:chrono for confirmation_request_delay

* Formatting

* Formatting

* Braced initialization test

* Clang formatting

* Move fast broadcast to block_processor::process_receive_one

* Remove extra checks

* static_cast<size_t>

* Fix

* FIx merge

* Add missing declaration

* Check if votes were already requested
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
functionality quality improvements This item indicates the need for or supplies a better way to implement existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants