Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing issue where blocks were not being rebroadcast immediately upon… #1657

Merged
merged 10 commits into from
Jan 30, 2019
Merged

Fixing issue where blocks were not being rebroadcast immediately upon… #1657

merged 10 commits into from
Jan 30, 2019

Conversation

zhyatt
Copy link
Collaborator

@zhyatt zhyatt commented Jan 29, 2019

… being inserted in to the ledger.

@zhyatt zhyatt requested review from cryptocode and SergiySW January 29, 2019 16:04
@zhyatt zhyatt added the quality improvements This item indicates the need for or supplies changes that improve maintainability label Jan 29, 2019
@zhyatt zhyatt added this to the V18.0 milestone Jan 29, 2019
@SergiySW SergiySW mentioned this pull request Jan 29, 2019
Merged
cryptocode
cryptocode approved these changes Jan 29, 2019
View reviewed changes
Copy link
Contributor

@cryptocode cryptocode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only question was if process_one should differentiate its logging on whether or not process_live gets called, but that doesn't seem like a blocker so LGTM.

@zhyatt zhyatt merged commit 17efbe4 into master Jan 30, 2019
@clemahieu clemahieu deleted the publish_latency branch March 20, 2019 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergiySW SergiySW SergiySW approved these changes

@cryptocode cryptocode cryptocode approved these changes

Assignees

@argakiig argakiig

Labels
quality improvements This item indicates the need for or supplies changes that improve maintainability
Projects
None yet
Milestone
V18.0
Development

Successfully merging this pull request may close these issues.
5 participants
@zhyatt @SergiySW @cryptocode @argakiig @clemahieu