Use random shuffle for active_transactions::request_confirm () #1691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for blocks rebroadcast & confirmation request in overload mode
cryptocode
approved these changes
Feb 4, 2019
argakiig
approved these changes
Feb 17, 2019
wezrule
reviewed
Feb 22, 2019
| requests_bundle.insert (std::make_pair (rep.endpoint, insert_vector)); | ||
| } | ||
| std::vector<std::pair<nano::block_hash, nano::block_hash>> insert_vector = { root_hash }; | ||
| requests_bundle.insert (std::make_pair (rep.endpoint, insert_vector)); |
There was a problem hiding this comment.
emplace can be used here as well (see other comment)
| { | ||
| while (requests_bundle.size () > max_broadcast_queue) | ||
| { | ||
| requests_bundle.erase (requests_bundle.begin ()); |
There was a problem hiding this comment.
you can probably use the ranged version of erase instead of a loop
| { | ||
| confirm_req_bundle.push_back (std::make_pair (i->election->status.winner, reps)); | ||
| } | ||
| confirm_req_bundle.push_back (std::make_pair (i->election->status.winner, reps)); |
There was a problem hiding this comment.
emplace_back can be used, which can save a copy/move, i.e:
confirm_req_bundle.emplace_back (i->election->status.winner, reps);
There was a problem hiding this comment.
Thanks!
Now I guess we better make proper ordering for active transactions instead of random
|
Closing in favor of #1810 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for blocks rebroadcast & confirmation request in overload mode