Trending active_transactions difficulty for an average #1858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 25, 2019 11:03
active_difficulty stored as atomic instead of function call
argakiig
added
enhancement
quality improvements
|
This is part of #1336 |
cryptocode
reviewed
Mar 25, 2019
clemahieu
reviewed
Mar 25, 2019
simplify roots avg calculation initialize circular buffer with threshold
clemahieu
reviewed
Mar 25, 2019
wezrule
reviewed
Mar 26, 2019
added 3 commits
March 26, 2019 14:20
init active_difficulty and difficulty_cb use std::accumulate rework test for active_difficulty polling cleanup and assert if not threshold
argakiig
requested review from
cryptocode,
wezrule and
clemahieu
and removed request for
wezrule
wezrule
approved these changes
Mar 28, 2019
clemahieu
approved these changes
Mar 30, 2019
guilhermelawless
pushed a commit
to guilhermelawless/nano-node
that referenced
this pull request
Apr 15, 2019
…1858) * difficulty polled into a circular buffer active_difficulty stored as atomic instead of function call * Adjust for 5 min trend * rpc to expose active_difficulty * use qualified root simplify roots avg calculation initialize circular buffer with threshold * remove deadline and system poll init active_difficulty and difficulty_cb use std::accumulate rework test for active_difficulty polling cleanup and assert if not threshold * missed usage of accumulate * use nano::uint128_t when applicable * merge cleanup * correct initialization order.
zhyatt
added
the
major
argakiig
added
the
documentation
zhyatt
removed
the
documentation
zhyatt
added
rpc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide active_transactions.active_difficulty for 5 min trended avg of adjusted_difficulty in active_transactions
alternative to #1725