recalculate work for long unconfirmed local blocks #1860
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
argakiig
added
enhancement
quality improvements
cryptocode
reviewed
Mar 25, 2019
…hem above the trended active_difficulty
|
rebased to dd46609 and adjusted to calculate new work above active_difficulty every announcement period. |
argakiig
removed
the
incomplete
wezrule
reviewed
Apr 3, 2019
wezrule
approved these changes
Apr 4, 2019
cryptocode
reviewed
Apr 4, 2019
| auto callback = [node_l, block_l, election_l](boost::optional<uint64_t> const & work_a) { | ||
| if (work_a && !nano::work_validate (block_l->root (), work_a.get ())) | ||
| { | ||
| block_l->block_work_set (work_a.get ()); |
There was a problem hiding this comment.
This updates a block's work field without a lock / it's not atomic.
Because of the block uniquer, I believe the same block can be accessed or have its work validated by other threads (such as the same block arriving again over bootstrap or realtime traffic)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
using a difficulty threshold of the long unconfirmed block
#1858 allows for recalculating with a threshold of active_difficulty instead
part of #1336