Recalculate work from wallet #1895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
argakiig
added
enhancement
functionality quality improvements
wezrule
suggested changes
Apr 11, 2019
SergiySW
reviewed
Apr 11, 2019
SergiySW
reviewed
Apr 11, 2019
SergiySW
reviewed
Apr 11, 2019
SergiySW
reviewed
Apr 16, 2019
… same block Test to update difficulty if below active_difficulty work recalc config option default 4 sec or 1/4 of announcement period
created thread to handle work regeneration based on user configurable input
only recalc work if considered online, peer stake is greater than delta or min conf
formatting
formatting
test was reworked block is generated and started to be processed block is added to difficulty_reque updated logic to handle test network
cryptocode
reviewed
Apr 16, 2019
cryptocode
reviewed
Apr 16, 2019
cryptocode
reviewed
Apr 16, 2019
cryptocode
reviewed
Apr 16, 2019
SergiySW
approved these changes
Apr 18, 2019
|
P.S. I guess for RC2 we may need to add some metrics to delay recalculation during network spam |
added 5 commits
April 22, 2019 10:19
do work regeneration drops junk blocks
pass lock into update_active_difficulty
moved transaction in do_work_regeneration outside loop to reuse check active and ledger for confirmation multiple times
cryptocode
reviewed
Apr 22, 2019
wezrule
reviewed
Apr 22, 2019
added 4 commits
April 22, 2019 12:45
repeat code to lambda
also should be fine as uint64_t since protected with mutex
cryptocode
approved these changes
Apr 22, 2019
wezrule
approved these changes
Apr 22, 2019
…nt and also the mutex matches the mutex we expect to be locked. This is the expected behavior. Store a mapping of qualified_root -> state_block since we only regenerate work for state_blocks and saves some type checking and complexity. The absence of the qualified_root in active_transactions indicates the block has been confirmed or it was a fork that was rejected, either way we don't need to generate more work for it, we don't need a different way to check if it's confirmed. Remove items from generated_blocks before we iterate over it so we don't have to modify the container while iterating. Fixed an issue where we were modifying a container while iterating over it with multimap::erase Moving forward declarations to beginning of namespace declaration so they're all in one place. Separating work_watcher from wallets since its sufficiently complex i.e. has its own mutex and condition variable. Constify a lot of functions that aren't labeled as such but are.
only evict block if we can ensure blocks are confirmed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replaces #1860
blocks handled by the internal wallets will have work calculated using the active_difficulty if active_difficulty is greater
creates a thread in wallets to track these blocks and the time they were inserted, if they arent confirmed they are re inserted with an updated time.