#272 manage starage and holder accounts #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s-medvedev
reviewed
Nov 9, 2021
otselnik
changed the title
otselnik
requested review from
sinev-valentine,
vasiliy-zaznobin and
s-medvedev
otselnik
changed the title
s-medvedev
reviewed
Nov 12, 2021
| } | ||
| } | ||
|
|
||
| result = client._provider.make_request("getAccountInfo", str(storage_account), opts) |
There was a problem hiding this comment.
Why you don't use client.get_account_info implementation?
There was a problem hiding this comment.
It returns full accounts data, wich is massive
|
|
||
| data = base64.b64decode(info['data'][0]) | ||
|
|
||
| empty = True if data[0] == 0 else False |
There was a problem hiding this comment.
I suggest returning the type of account (instead of the empty flag) here.
Rationale: we will change the Storage account logic and empty storage will be in two cases Empty and FinalizedStorage.
s-medvedev
approved these changes
Nov 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
new_acc_id_globandacc_list_globglobal variables for acquiring or creating storage and holder accounts.PermanentAccountscreation prior iterative transaction execution.TransactionInfostructure.TransactionInfostructure.Storage/Holder accounts distribution and acquiring:
new_acc_id_globis used for generating new addresses.acc_list_globis used to store previously generated addresses that are not already in use.acc_list_glob, it is taken from there. otherwise id got from incrementednew_acc_id_glob.