289 implement eth get storage at #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivandzen
requested review from
anton-lisanin,
s-medvedev and
vasiliy-zaznobin
vasiliy-zaznobin
previously approved these changes
Nov 17, 2021
s-medvedev
reviewed
Nov 17, 2021
added 2 commits
November 17, 2021 20:23
s-medvedev
approved these changes
Nov 18, 2021
vasiliy-zaznobin
pushed a commit
that referenced
this pull request
Dec 7, 2021
* create eth_getStorageAt prototype * implement eth_getStorageAt * fix test * Fix review issues, add UTs * handle neon-cli errors * add test Co-authored-by: ivanl <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement eth_getStorageAt RPC method, add UT