Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#354 Check result for errors #355

Merged
merged 5 commits into from
Dec 7, 2021
Merged

Conversation

otselnik
Copy link
Contributor

@otselnik otselnik commented Dec 6, 2021

0x6ac954d8f9e7c0bf0c6f9bc0747faf550a84b5dff63b832efd8910925e1b9f99 transaction in UniSwap tests sometimes successfully executes in noniterative execution and sometimes successfully simulates on validator and than fails on execution.
These changes catch this situation and resume execution iteratively.
Else catches fail on accounts creation.

@otselnik otselnik marked this pull request as ready for review December 6, 2021 20:59
@otselnik otselnik self-assigned this Dec 6, 2021
@otselnik
Copy link
Contributor Author

otselnik commented Dec 6, 2021

It won't fix a problem with getting measurements. It needs to be rewritten somehow.
https://buildkite.com/cyberway/neon-proxy/builds/2826# is a good example

@s-medvedev s-medvedev merged commit 521696f into develop Dec 7, 2021
@s-medvedev s-medvedev deleted the 354_check_result_for_errors branch December 7, 2021 12:08
vasiliy-zaznobin pushed a commit that referenced this pull request Dec 7, 2021
* #354 Check result for errors

* #354 get_measurements error -> warning

* #354 check for errors in get measurements

* #354 get measurements from bucked transactions

* #354 remove repeated code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants