Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Mark over 65535 unread items as "read" #2557

Merged
merged 5 commits into from
Jan 25, 2024
Merged

Conversation

IgorA100
Copy link
Contributor

If there are more than 65535 unread items, then when checking “mark as read” you will get an SQL error (SQLSTATE[HY000]: General error: 7 number of parameters must be between 0 and 65535 at) due to the limitation of the number of parameters. The array is divided into smaller ones.

Summary

Checklist

If there are more than 65535 unread items, then when checking “mark as read” you will get an SQL error (SQLSTATE[HY000]: General error: 7 number of parameters must be between 0 and 65535 at) due to the limitation of the number of parameters. The array is divided into smaller ones.

Signed-off-by: IgorA100 <[email protected]>
Copy link
Contributor

@SMillerDev SMillerDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. One small nitpick.

Update CHANGELOG.md

Signed-off-by: IgorA100 <[email protected]>
Signed-off-by: IgorA100 <[email protected]>
@Grotax Grotax merged commit 4f5cf49 into nextcloud:master Jan 25, 2024
20 of 21 checks passed
@Grotax
Copy link
Member

Grotax commented Jan 25, 2024

Thanks :-)

Grotax added a commit that referenced this pull request Jan 25, 2024
Changed
- Add DB index for news_feeds.deleted_at (#2526)

Fixed
- PostgreSQL implement fix for marking over 65535 unread items as "read" (#2557)

Signed-off-by: Benjamin Brahmer <[email protected]>
@Grotax Grotax mentioned this pull request Jan 25, 2024
Grotax added a commit that referenced this pull request Jan 25, 2024
Changed
- Add DB index for news_feeds.deleted_at (#2526)

Fixed
- PostgreSQL implement fix for marking over 65535 unread items as "read" (#2557)

Signed-off-by: Benjamin Brahmer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SQLSTATE[HY000]: General error: 7 number of parameters must be between 0 and 65535 at
3 participants