Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Mark over 65535 unread items as "read" #2557

Merged
merged 5 commits into from
Jan 25, 2024
Merged

Fix: Mark over 65535 unread items as "read" #2557

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c7510f4
Fix: Mark over 65535 unread items as "read"
IgorA100 Jan 20, 2024
18f8b1c
Update CHANGELOG.md
IgorA100 Jan 20, 2024
f87aea9
Cancel preserve keys of the items array.
IgorA100 Jan 20, 2024
6ad9cc9
Replacing tabs with spaces
IgorA100 Jan 21, 2024
507785c
Styling
IgorA100 Jan 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 23 additions & 16 deletions lib/Db/FeedMapperV2.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,21 +186,28 @@ function ($value): int {
},
$this->db->executeQuery($idBuilder->getSQL(), $idBuilder->getParameters())->fetchAll()
);
$time = new Time();
$builder = $this->db->getQueryBuilder();
$builder->update(ItemMapperV2::TABLE_NAME)
->set('unread', $builder->createParameter('unread'))
->set('last_modified', $builder->createParameter('last_modified'))
->andWhere('id IN (:idList)')
->andWhere('unread != :unread')
->setParameter('unread', false, IQueryBuilder::PARAM_BOOL)
->setParameter('idList', $idList, IQueryBuilder::PARAM_INT_ARRAY)
->setParameter('last_modified', $time->getMicroTime(), IQueryBuilder::PARAM_STR);

return $this->db->executeStatement(
$builder->getSQL(),
$builder->getParameters(),
$builder->getParameterTypes()
);

$chunked_idList = array_chunk($idList,65500,true);
$res = 0;
foreach ($chunked_idList as $idList_chunk)
{
$time = new Time();
$builder = $this->db->getQueryBuilder();
$builder->update(ItemMapperV2::TABLE_NAME)
->set('unread', $builder->createParameter('unread'))
->set('last_modified', $builder->createParameter('last_modified'))
->andWhere('id IN (:idList)')
->andWhere('unread != :unread')
->setParameter('unread', false, IQueryBuilder::PARAM_BOOL)
->setParameter('idList', $idList_chunk, IQueryBuilder::PARAM_INT_ARRAY)
->setParameter('last_modified', $time->getMicroTime(), IQueryBuilder::PARAM_STR);

$res += $this->db->executeStatement(
$builder->getSQL(),
$builder->getParameters(),
$builder->getParameterTypes()
);
}
return $res;
}
}
Loading