Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin page translation issue #2022

Closed
Loki3000 opened this issue Nov 4, 2016 · 4 comments
Closed

Admin page translation issue #2022

Loki3000 opened this issue Nov 4, 2016 · 4 comments
Labels

Comments

@Loki3000
Copy link
Contributor

Loki3000 commented Nov 4, 2016

Steps to reproduce

  1. open /index.php/settings/admin url
  2. look at left menu

Expected behaviour

Expected that left menu is localized

Actual behaviour

Localized only one item of left menu

Server configuration

Operating system:
ubuntu 16.4
Web server:
Apache2
Database:
mysql 5.7.16
PHP version:
PHP 7.0.12
Nextcloud version: (see Nextcloud admin page)
10.0.1 (stable)
Updated from an older Nextcloud/ownCloud or fresh install:
Updated form ownCloud

I've a little dig in this problem and get follow:
in lib/private/Settings/Manager.php:332

0 => [new Section('server', $this->l->t('Server settings'), 0)],

$this->l contains strings from core/l10n/*.json file
but required string 'Server settings' (and followed strings) contains in file lib/l10n/*.json

@MariusBluem
Copy link
Member

Could you have a look into that 😁 @MorrisJobke ... On Transifex it seems to be translated 🤔

@Loki3000
Copy link
Contributor Author

Loki3000 commented Nov 6, 2016

Yes strings translated, but placed in other dir:
file loaded into $this->l object
core/l10n/*.json

file contains required strings
lib/l10n/*.json

@MariusBluem
Copy link
Member

@Loki3000 you may want to fix this directly over an PR? 😁

@Loki3000
Copy link
Contributor Author

Loki3000 commented Nov 6, 2016

I don't know right solution. Maybe translate strings placed in wrong place, and also maybe that to Manager.php was sent wrong object as a parameter.
Someone who knows the code should confirm that it is not the second case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants