-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v2.0 Release Candidate #119
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dshinzie
reviewed
May 26, 2022
Replace gawk containers with ubuntu
FriederikeHanssen
requested changes
May 27, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it, just some teeny tiny things from my side mostly about version and test data.
Release Updates
v2.0 updates
FriederikeHanssen
approved these changes
Jun 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major Changes
igg
and the process of assigning controls to samples has been simplified.peakcaller
variable. Both peak callers can be run using--peakcaller SEACR,MACS2
, the primary caller is the first item in the list and will be used downstream while the secondary will be run and outputted to the results folder.v1.1
ran consensus peak calling at both the group level and for all samples. This was causing performance issues for larger sample sets. There is now a newconsensus_peak_mode
parameter that defaults togroup
. Consensus will only be run on all samples if this is changed toall
.Enhancements
2.3.2
.gff
andfna
file extensions.--end-to-end
mode only if trimming is skipped. If trimming is activated then it will run in--local
mode.Fixes
Software dependencies
Note, since the pipeline is now using Nextflow DSL2, each process will be run with its own Biocontainer. This means that on occasion it is entirely possible for the pipeline to be using different versions of the same tool. However, the overall software dependency changes compared to the last release have been listed below for reference.
samtools
bowtie2
picard
PR checklist
nf-core lint
).nextflow run . -profile test,docker
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).