feat: allow overriding stream implementation #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcollina
requested changes
May 3, 2020
ronag
force-pushed
the
override-stream
branch
2 times, most recently
from
62c0c9c to
3fb9af0
Compare
|
PTAL |
|
CI is failing :( |
|
Travis was building from old version, guess it still has some kind of race problems. Forced a restart. |
|
I'm confused... travis is failing on a line of code that does not exist? |
|
Ah, travis merges against master. |
ronag
force-pushed
the
override-stream
branch
2 times, most recently
from
e1162a6 to
32957b9
Compare
|
there are still conflicts |
|
new conflicts resolved |
|
lol, more conflicts |
ronag
force-pushed
the
override-stream
branch
2 times, most recently
from
2ff8adc to
19b4ee7
Compare
|
fixed again |
|
still conflicts :( |
|
argh, fixed again |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #17