Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Notary website redesign #139

Merged
merged 2 commits into from
Feb 22, 2023
Merged

Feat: Notary website redesign #139

merged 2 commits into from
Feb 22, 2023

Conversation

thisisobate
Copy link
Contributor

@thisisobate thisisobate commented Feb 22, 2023 •
edited
Loading

Duplicate of #110
Fixes #113
Fixes #112
Todos

  • Flesh out hero section
  • Style the buttons - assigned to Hamees
  • Create feature card component - assigned to Hamees
  • Create layout/structure using plain HTML
  • Style page
  • Implement mobile responsiveness
  • Convert HTML to Hugo templates
  • Update the landing page based on the latest change
  • Update content with real data
  • Add two links to two buttons
  • Move the logo to corner at the top left
  • Change Resources to Blog for the first version
  • Pull the updates from the latest main branch for /doc
  • Clean code
    • fix font sizing
    • remove redundant code
    • maintain consistent units

Follow-up PR

  • Make the “News & Blogs” section to be dynamic
  • Split file into components

@thisisobate
Feat: Notary website redesign
8a40b13 
Co-authored-by: Hamees Sayed <[email protected]>

Signed-off-by: thisisobate <[email protected]>
@thisisobate thisisobate requested a review from yizha1 as a code owner February 22, 2023 09:16
@netlify
Copy link

netlify bot commented Feb 22, 2023 •
edited
Loading

✅ Deploy Preview for notarydev ready!

Name Link
🔨 Latest commit df2b1c5
🔍 Latest deploy log https://app.netlify.com/sites/notarydev/deploys/63f5e16b59f17a0008f11675
😎 Deploy Preview https://deploy-preview-139--notarydev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@thisisobate thisisobate mentioned this pull request Feb 22, 2023
Closed
19 tasks
FeynmanZhou
FeynmanZhou approved these changes Feb 22, 2023
View reviewed changes
Copy link
Member

@FeynmanZhou FeynmanZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

yizha1
yizha1 approved these changes Feb 22, 2023
View reviewed changes
Copy link
Contributor

@yizha1 yizha1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vaninrao10
vaninrao10 approved these changes Feb 22, 2023
View reviewed changes
Copy link

@vaninrao10 vaninrao10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

toddysm
toddysm approved these changes Feb 22, 2023
View reviewed changes
Copy link
Contributor

@toddysm toddysm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FeynmanZhou FeynmanZhou merged commit d6cb9a4 into notaryproject:main Feb 22, 2023
@thisisobate thisisobate mentioned this pull request Feb 28, 2023
Closed
7 tasks
@FeynmanZhou FeynmanZhou mentioned this pull request May 10, 2023
Closed
@SiddheshKukade SiddheshKukade mentioned this pull request May 16, 2023
Open
@ArafatAbdussalam
Copy link

Hi @FeynmanZhou I am an LFX applicant and I will like to work on this project

@Sukhendu2002
Copy link

Hello @FeynmanZhou, my name is Sukhendu Sekhar Guria, and I am an LFX applicant. I am interested in contributing to this project. Could you please provide me with any helpful resources to get started? Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toddysm toddysm toddysm approved these changes

@FeynmanZhou FeynmanZhou FeynmanZhou approved these changes

@yizha1 yizha1 yizha1 approved these changes

@vaninrao10 vaninrao10 vaninrao10 approved these changes

@iamsamirzon iamsamirzon Awaiting requested review from iamsamirzon iamsamirzon is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
7 participants
@thisisobate @ArafatAbdussalam @Sukhendu2002 @toddysm @FeynmanZhou @yizha1 @vaninrao10