Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Notary Website Redesign #110

Closed
wants to merge 145 commits into from
Closed

Feat: Notary Website Redesign #110

wants to merge 145 commits into from

Conversation

thisisobate
Copy link
Contributor

@thisisobate thisisobate commented Dec 8, 2022 •
edited
Loading

Todos

  • Flesh out hero section
  • Style the buttons - assigned to Hamees
  • Create feature card component - assigned to Hamees
  • Create layout/structure using plain HTML
  • Style page
  • Implement mobile responsiveness
  • Convert HTML to Hugo templates
  • Update the landing page based on the latest change
  • Update content with real data
  • Add two links to two buttons
  • Move the logo to corner at the top left
  • Change Resources to Blog for the first version
  • Pull the updates from the latest main branch for /doc
  • Clean code
    • fix font sizing
    • remove redundant code
    • maintain consistent units

Follow-up PR

  • Make the “News & Blogs” section to be dynamic
  • Split file into components

caniszczyk and others added 30 commits February 13, 2020 14:44
@caniszczyk
Initial commit
80958f8
@nate-double-u
Adding .github/settings.yml (#1)
386a9fa 
Setting repo defaults, labels

Adding caniszczyk as admin, nate-double-u as maintainer

Signed-off-by: Nate W <[email protected]>
@nate-double-u
updating github settings to include default labels
7bd8331 
Signed-off-by: Nate W <[email protected]>
@nate-double-u
Merge pull request #2 from nate-double-u/labels-update
d19e443 
Updating repo settings to include default labels.

Signed-off-by: Nate W <[email protected]>
@nate-double-u
Adding new maintainers to .github/settings.yml (#4)
4a43fc0 
Signed-off-by: Nate W <[email protected]>
@nate-double-u
Update .github/settings.yml (#8)
333fc05 
Adding justincormack as an admin & chalin as a maintainer.
Signed-off-by: Nate W <[email protected]>
@nate-double-u
Setting up notaryproject.dev with hugo/netlify/docsy - cloning etcd-i…
bb4a6f9 
…o/website. (#9)

Signed-off-by: Nate W <[email protected]>
@nate-double-u
Update .github/settings.yml with new labels (#19)
ee7193c 
Adding labels to the repo:
- infrastructure
- ux
- design
- upstream
- blocked
- dependencies

Signed-off-by: Nate W <[email protected]>
@nate-double-u
Update config.yaml (#24)
0fcab2e 
Update config.yaml with correct project description

Signed-off-by: Nate W <[email protected]>
@chalin
README: add link definitions and other fixes (#33)
9edd43b 
- Add missing markdown link definitions
- Drop mention of `make docker-serve`, which doesn't exist
@chalin
Update LICENSE (#35)
fe5a16a
@chalin
Add external link checking, and other improvements (#39)
e15d562 
Signed-off-by: Patrice Chalin <[email protected]>
@chalin
Render-link: trim whitespace from end template (#40)
da79a35
@nate-double-u
Update cncf.html (#36)
48472bf 
Updating project status to incubating.

Signed-off-by: Nate W <[email protected]>
@SteveLasker
Notary v2 Alpha 1 release blog (#48)
8cfbeb6 
* Notary v2 Alpha 1 release blog

Signed-off-by: Steve Lasker <[email protected]>
Signed-off-by: Nate W <[email protected]>
@imjasonh
Update announcing-notation-alpha1.md
fb4796b 
Signed-off-by: Jason Hall <[email protected]>
@SteveLasker
Merge pull request #49 from imjasonh/patch-1
40a9e72 
Address some minor feedback on announcement blog post
@imjasonh
Fix another small typo in release announcement (#50)
ce661ef
@nate-double-u
Updating the community page (#46)
bfd700d 
* updating community page with CNCF Public Events calendar iframe

Signed-off-by: Nate W <[email protected]>
@chalin
NPM script updates (#51)
c9a0b2f 
- serve script: drop unnecessary flag
- Refresh of submodule scripts

Signed-off-by: Patrice Chalin <[email protected]>
@chalin
Build config simplification & script tweak (#52)
c664225 
Signed-off-by: Patrice Chalin <[email protected]>
@nate-double-u
Setting up Gitpod.io .gitpod.yml file for a cloud IDE (#54)
40d3ded 
* Setting up Gitpod.io .gitpod.yml file for cloud IDE

Signed-off-by: Nate W <[email protected]>
@nate-double-u
Refactoring to match proposed information architecture (#31)
fcf82a1 
* Refactoring folder structure and top navigation menu to match the proposed information architecture.

Signed-off-by: Nate W <[email protected]>
@mnm678
Add myself to the collaborators
f1c2d61 
Signed-off-by: Marina Moore <[email protected]>
@nate-double-u
updating subproject descriptions and showing them on the docs landing…
544e24d 
… page. (#56)
@SteveLasker
Merge pull request #57 from mnm678/add-marina
18b5039 
Add Marina Moore to the collaborators
@nate-double-u
adding Notary v2 community notes archive (#59)
a7304a2
@nate-double-u
removing space from right side of top menu bar by removing versioning (…
e09dd11 
…#60)

Signed-off-by: Nate W <[email protected]>
@chalin
Update build setup instructions: the repo must be cloned (#63)
b4ea308
@nate-double-u
Updating README with cloud IDE info (#62)
d106bfb 
* Updating README file to include information about available cloud IDE options for development.
* adding nvm install --lts

Signed-off-by: Nate W <[email protected]>
@FeynmanZhou FeynmanZhou self-requested a review February 20, 2023 14:11
yizha1
yizha1 previously approved these changes Feb 20, 2023
View reviewed changes
Copy link
Contributor

@yizha1 yizha1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks @thisisobate for your contribution!

@FeynmanZhou FeynmanZhou requested a review from yizha1 February 20, 2023 16:14
FeynmanZhou
FeynmanZhou previously approved these changes Feb 20, 2023
View reviewed changes
Copy link
Member

@FeynmanZhou FeynmanZhou left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We are ready to merge it and push the new website to production.

yizha1
yizha1 previously approved these changes Feb 21, 2023
View reviewed changes
Copy link
Contributor

@yizha1 yizha1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. woot~

vaninrao10
vaninrao10 previously approved these changes Feb 21, 2023
View reviewed changes
Copy link

@vaninrao10 vaninrao10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove "Signer" word from the AWS section. It should be only AWS. You can open a new PR and take care of this comment. Rest contents LGTM.

priteshbandi
priteshbandi previously approved these changes Feb 21, 2023
View reviewed changes
Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

toddysm
toddysm requested changes Feb 21, 2023
View reviewed changes
content/en/_index.html Outdated
</div>
<div class="text-container text-left">
<p>
AWS Signer team is using and contributing to Notation, building the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vaninrao10 requested that we remove the Signer from the text.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@toddysm As Vani mentioned above, this will be addressed in a follow-up PR. I will raise a PR to update the description. Let's agree on merging Uche's change first.

Copy link
Contributor Author

@thisisobate thisisobate Feb 21, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I already pushed a fix for this.
I'm trying to fix the issue of commits not being verified. @toddysm

content/en/_index.html Outdated
</div>
<div class="text-container text-left">
<p>
Zot registry supports store Notation signature as OCI artifacts
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have confirmation from the Zot team that we can use their name?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. We confirmed with Ramkumar from the Zot team in a community call.

content/en/_index.html Outdated
<img src="aws_logo.svg" alt="AWS logo" />
</div>
<div class="img-container-mdl is-centered">
<img src="cncf_logo.svg" alt="CNCF logo" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure how "In collaboration with CNCF" sounds in this context. Notary is a CNCF project but I think we should list only collaborators.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This list includes major contributor and collaborator organizations. It's fine to add CNCF's logo to the contributor org list since CNCF has employees who are contributing to Notary

@FeynmanZhou FeynmanZhou requested a review from toddysm February 21, 2023 16:17
@thisisobate
chore: nit fix
c2cde2d 
Signed-off-by: thisisobate <[email protected]>
@iamsamirzon
Copy link
Contributor

@toddysm , @FeynmanZhou - I have more than a few comments, mostly nits. What is the best way to provide that? I can't seem to provide inline comments in the https://deploy-preview-110--notarydev.netlify.app/
cc: @vaninrao10

@FeynmanZhou
Copy link
Member

@toddysm , @FeynmanZhou - I have more than a few comments, mostly nits. What is the best way to provide that? I can't seem to provide inline comments in the https://deploy-preview-110--notarydev.netlify.app/ cc: @vaninrao10

@iamsamirzon Could you screenshot your suggested changes and paste them here?

@thisisobate thisisobate mentioned this pull request Feb 22, 2023
Merged
19 tasks
@thisisobate
Copy link
Contributor Author

Couldn't make commits to be verifiable in this PR so I decided to create a new one.
Closed in favor of #139

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FeynmanZhou FeynmanZhou FeynmanZhou left review comments

@priteshbandi priteshbandi priteshbandi left review comments

@yizha1 yizha1 yizha1 left review comments

@vaninrao10 vaninrao10 vaninrao10 left review comments

@iamsamirzon iamsamirzon Awaiting requested review from iamsamirzon iamsamirzon is a code owner

@toddysm toddysm Awaiting requested review from toddysm toddysm is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.