Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backport: CRL cache with log and E2E tests from main to release-1.3 #1117

Merged
merged 4 commits into from
Dec 20, 2024
Merged

backport: CRL cache with log and E2E tests from main to release-1.3 #1117

merged 4 commits into from
Dec 20, 2024

Conversation

Two-Hearts
Copy link
Contributor

@Two-Hearts Two-Hearts commented Dec 19, 2024 •
edited by shizhMSFT
Loading

This PR backports changes related to crl cache from main to release-1.3 branch.

PRs that's backporting:

This PR targets release-1.3 branch.

@Two-Hearts
fix test
277311d 
Signed-off-by: Patrick Zheng <[email protected]>
@codecov Codecov
Copy link

codecov bot commented Dec 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.72%. Comparing base (141bdf1) to head (277311d).
Report is 1 commits behind head on release-1.3.

Additional details and impacted files 
@@               Coverage Diff               @@
##           release-1.3    #1117      +/-   ##
===============================================
+ Coverage        70.35%   70.72%   +0.37%     
===============================================
  Files               46       47       +1     
  Lines             2911     2948      +37     
===============================================
+ Hits              2048     2085      +37     
  Misses             670      670              
  Partials           193      193

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JeyJeyGao
Copy link
Contributor

JeyJeyGao commented Dec 19, 2024 •
edited
Loading

It looks like this PR includes #1076, #1078, and #1079.

For #1079, which is the test for the entire CRL feature and not limited to the cache, should we update the PR name to:

backport: CRL cache and CRL E2E test from main to release-1.3 branch

Also, please mention the PRs that we are backporting in the PR description. Thanks! @Two-Hearts

@Two-Hearts Two-Hearts changed the title backport: crl cache from main to release-1.3 branch backport: crl from main to release-1.3 branch Dec 19, 2024
@Two-Hearts
Copy link
Contributor Author

It looks like this PR includes #1076, #1078, and #1079.

For #1079, which is the test for the entire CRL feature and not limited to the cache, should we update the PR name to:

backport: CRL cache and CRL E2E test from main to release-1.3 branch

Also, please mention the PRs that we are backporting in the PR description. Thanks! @Two-Hearts

@JeyJeyGao Updated.

JeyJeyGao
JeyJeyGao approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JeyJeyGao
Copy link
Contributor

Is it expected that the test/e2e/go.mod bump is also included in this PR?

@Two-Hearts
Copy link
Contributor Author

Is it expected that the test/e2e/go.mod bump is also included in this PR?

It was brought in by PR: #1079.

@shizhMSFT shizhMSFT changed the title backport: crl from main to release-1.3 branch backport: CRL cache from main to release-1.3 Dec 19, 2024
@shizhMSFT shizhMSFT changed the title backport: CRL cache from main to release-1.3 backport: CRL changes from main to release-1.3 Dec 19, 2024
@shizhMSFT shizhMSFT changed the title backport: CRL changes from main to release-1.3 backport: CRL with log and E2E tests from main to release-1.3 Dec 19, 2024
shizhMSFT
shizhMSFT approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT changed the title backport: CRL with log and E2E tests from main to release-1.3 backport: CRL cache with log and E2E tests from main to release-1.3 Dec 19, 2024
vaninrao10
vaninrao10 approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@vaninrao10 vaninrao10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Two-Hearts Two-Hearts merged commit 8c20002 into notaryproject:release-1.3 Dec 20, 2024
7 checks passed
@Two-Hearts Two-Hearts deleted the crl branch December 20, 2024 00:03
@Two-Hearts Two-Hearts mentioned this pull request Dec 30, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shizhMSFT shizhMSFT shizhMSFT approved these changes

@JeyJeyGao JeyJeyGao JeyJeyGao approved these changes

@vaninrao10 vaninrao10 vaninrao10 approved these changes

@gokarnm gokarnm Awaiting requested review from gokarnm gokarnm is a code owner

@NiazFK NiazFK Awaiting requested review from NiazFK NiazFK is a code owner

@priteshbandi priteshbandi Awaiting requested review from priteshbandi priteshbandi is a code owner

@rgnote rgnote Awaiting requested review from rgnote rgnote is a code owner

@toddysm toddysm Awaiting requested review from toddysm toddysm is a code owner

@yizha1 yizha1 Awaiting requested review from yizha1 yizha1 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Two-Hearts @JeyJeyGao @shizhMSFT @vaninrao10