Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump: release v1.3.0-rc.2 #1130

Merged
merged 1 commit into from
Dec 30, 2024

Conversation

Two-Hearts
Copy link
Contributor

@Two-Hearts Two-Hearts commented Dec 30, 2024

Release

This would mean tagging 260968a as v1.3.0-rc.2 to release.

Vote

We need at least 4 approvals from 6 maintainers to release v1.3.0-rc.2.

What's Changed

Full Changelog: v1.3.0-rc.1...260968a

Actions

Please review the PR and vote by approving.

Signed-off-by: Patrick Zheng <[email protected]>
Copy link

codecov bot commented Dec 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.79%. Comparing base (3351c95) to head (260968a).
Report is 2 commits behind head on release-1.3.

Additional details and impacted files
@@             Coverage Diff              @@
##           release-1.3    #1130   +/-   ##
============================================
  Coverage        70.79%   70.79%           
============================================
  Files               48       48           
  Lines             2945     2945           
============================================
  Hits              2085     2085           
  Misses             668      668           
  Partials           192      192           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Two-Hearts
Copy link
Contributor Author

LGTM

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Two-Hearts Two-Hearts merged commit 9d5b421 into notaryproject:release-1.3 Dec 30, 2024
7 checks passed
@Two-Hearts Two-Hearts deleted the release-1.3 branch December 30, 2024 23:46
@Two-Hearts Two-Hearts mentioned this pull request Jan 16, 2025
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants