spec: add CLI notation certificate and key specs #361
Conversation
Signed-off-by: Yi Zha <[email protected]>
Signed-off-by: Yi Zha <[email protected]>
Signed-off-by: Yi Zha <[email protected]>
Signed-off-by: Yi Zha <[email protected]>
yizha1
requested review from
dtzar,
gokarnm,
binbin-li,
priteshbandi,
shizhMSFT,
FeynmanZhou,
iamsamirzon and
patrickzheng200
yizha1
changed the title
Signed-off-by: Yi Zha <[email protected]>
| -d, --default mark as default | ||
| -h, --help help for generate-test | ||
| -n, --name string key and certificate name | ||
| --trust add the generated certificate to the trust store |
There was a problem hiding this comment.
Since we have trust policy and trust store, we need to elaborate what --trust means.
There was a problem hiding this comment.
I think the description is clear for --trust. Do you mean we need to change the name of --trust for trust store only? For example --trust-store?
There was a problem hiding this comment.
This flag only adds the generated certificate to the trust stone, no operations on trust policy.
Signed-off-by: Yi Zha <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #361 +/- ##
==========================================
+ Coverage 30.54% 32.03% +1.49%
==========================================
Files 25 26 +1
Lines 1614 1670 +56
==========================================
+ Hits 493 535 +42
- Misses 1108 1122 +14
Partials 13 13
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: Yi Zha <[email protected]>
Signed-off-by: Yi Zha <[email protected]>
Signed-off-by: Yi Zha <[email protected]>
Signed-off-by: Yi Zha <[email protected]>
Signed-off-by: Yi Zha <[email protected]>
| Update key in signing key list | ||
|
|
||
| Usage: | ||
| notation key update [flags] <key_name> |
There was a problem hiding this comment.
Whats the purpose/ intended use of update command? Is it just to update default key? if so, the --default flag becomes mandatory here.
Also, if it its only for updating default key, should we rename it to update-default ?
There was a problem hiding this comment.
Currently only one flag '--default', there could be more later.
Signed-off-by: Yi Zha <[email protected]>
No description provided.