Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
spec: add CLI notation certificate and key specs #361
spec: add CLI notation certificate and key specs #361
Changes from all commits
df1e729
bcc2ea4
f72b2a6
1950096
4b76dfc
c0f2d12
8735263
e91aff5
9d0d156
7ddfebd
75dd7aa
b9dd137
2c71fc1
b38440e
7bc605c
626d8b4
4ebb19c
6f996f4
826a441
020b53b
2b53e4f
75e89c7
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we have trust policy and trust store, we need to elaborate what
--trust
means.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the description is clear for
--trust
. Do you mean we need to change the name of--trust
for trust store only? For example--trust-store
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This flag only adds the generated certificate to the trust stone, no operations on trust policy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whats the purpose/ intended use of update command? Is it just to update default key? if so, the --default flag becomes mandatory here.
Also, if it its only for updating default key, should we rename it to
update-default
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently only one flag '--default', there could be more later.