-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): exponential backoff retry on cache put fail #21926
fix(core): exponential backoff retry on cache put fail #21926
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 41a4009. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Hi @FrozenPandaz, could you please let me know if you have time to review this change, or if there's something else I need to do before getting this PR reviewed? Thanks. |
The changes look good. Currently, it would go a very long time before actually giving up. I decreased the amount of maximum time it will wait. |
Co-authored-by: FrozenPandaz <[email protected]> (cherry picked from commit 16af95f)
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This PR fixes the same issue as #7349, but implements a more resilient and less aggressive retry strategy. I regularly get cache errors on my pipeline, because I share the same local cache (i.e. EFS) between multiple EC2 agents. This is hard to reproduce since it's a race condition on my custom set-up. Given that this change won't affect the normal performance (since it's just an edge case), I think this change would be a nice-to-have.