Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): exponential backoff retry on cache put fail #21926

Merged
merged 4 commits into from
Mar 22, 2024
Merged

fix(core): exponential backoff retry on cache put fail #21926

merged 4 commits into from
Mar 22, 2024

Conversation

mike-fam
Copy link
Contributor

This PR fixes the same issue as #7349, but implements a more resilient and less aggressive retry strategy. I regularly get cache errors on my pipeline, because I share the same local cache (i.e. EFS) between multiple EC2 agents. This is hard to reproduce since it's a race condition on my custom set-up. Given that this change won't affect the normal performance (since it's just an edge case), I think this change would be a nice-to-have.

@mike-fam mike-fam requested a review from a team as a code owner February 22, 2024 02:10
Copy link

vercel bot commented Feb 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Mar 22, 2024 8:26pm

@mike-fam mike-fam changed the title fix(core): exponential retry on cache put fail fix(core): exponential backoff retry on cache put fail Feb 22, 2024
@mike-fam
Copy link
Contributor Author

mike-fam commented Mar 2, 2024

Hi @FrozenPandaz, could you please let me know if you have time to review this change, or if there's something else I need to do before getting this PR reviewed? Thanks.

@FrozenPandaz
Copy link
Collaborator

The changes look good. Currently, it would go a very long time before actually giving up. I decreased the amount of maximum time it will wait.

@FrozenPandaz FrozenPandaz merged commit 16af95f into nrwl:master Mar 22, 2024
6 checks passed
FrozenPandaz pushed a commit that referenced this pull request Mar 25, 2024
Co-authored-by: FrozenPandaz <[email protected]>
(cherry picked from commit 16af95f)
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants