Single execute signatures #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akolotov
reviewed
Jan 16, 2020
akolotov
requested changes
Jan 16, 2020
akolotov
requested changes
Jan 16, 2020
There was a problem hiding this comment.
Please consider to introduce new version in https://github.com/poanetwork/tokenbridge-contracts/blob/master/contracts/upgradeable_contracts/VersionableBridge.sol. Since the changes we are making under this PR broke backward compatibility (the bridge will not work with old scheme of packing signatures) my suggestion is to increase the major part of the version number.
akolotov
approved these changes
Jan 17, 2020
patitonar
approved these changes
Jan 20, 2020
This was referenced Jan 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #354