Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mark kotlin as runtime dependency #113

Closed
wants to merge 1 commit into from

Conversation

Hailong-am
Copy link
Collaborator

@Hailong-am Hailong-am commented Jan 9, 2024

Description

image

the compiled class in common-utils have dependency on kotlin-stdlib, change it to implementation

Issues Resolved

2024-01-09 10:51:25.521	
[2024-01-09T02:51:25,518][ERROR][o.o.b.OpenSearchUncaughtExceptionHandler] [opensearch-cluster-master-1] fatal error in thread [Thread-1693], exiting

2024-01-09 10:51:25.521	
java.lang.NoClassDefFoundError: kotlin/jvm/internal/Intrinsics
2024-01-09 10:51:25.521	
	at org.opensearch.commons.alerting.model.Table.<init>(Table.kt) ~[?:?]
2024-01-09 10:51:25.521	
	at org.opensearch.agent.tools.SearchAlertsTool.run(SearchAlertsTool.java:81) ~[?:?]
2024-01-09 10:51:25.521	
	at org.opensearch.ml.engine.algorithms.agent.MLChatAgentRunner.lambda$runReAct$6(MLChatAgentRunner.java:481) ~[?:?]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@Hailong-am
Copy link
Collaborator Author

Hailong-am commented Jan 9, 2024

build failure fixed by #114

Copy link

codecov bot commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7a596a0) 81.70% compared to head (335faa7) 81.70%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #113   +/-   ##
=========================================
  Coverage     81.70%   81.70%           
  Complexity      190      190           
=========================================
  Files            13       13           
  Lines           962      962           
  Branches        130      130           
=========================================
  Hits            786      786           
  Misses          126      126           
  Partials         50       50           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Hailong-am Hailong-am marked this pull request as draft January 9, 2024 05:45
@Hailong-am
Copy link
Collaborator Author

should add kotlin-stdlib into ml-commons, close it

@Hailong-am Hailong-am closed this Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant