Fix compile error #114
Merged
Fix compile error #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hailong Cui <[email protected]>
Hailong-am
requested review from
b4sjoo,
dhrubo-os,
jngz-es,
model-collapse,
rbhavna,
ylwu-amzn,
zane-neo,
Zhangxunmt,
xinyual,
amitgalitz,
jackiehanyang,
owaiskazi19,
ohltyler,
joshpalis,
dbwiddis,
kaituo,
lezzago,
eirsep,
sbcd90,
zhichao-aws and
joshuali925
as code owners
dbwiddis
approved these changes
Jan 9, 2024
Signed-off-by: Hailong Cui <[email protected]>
5 tasks
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #114 +/- ##
============================================
+ Coverage 81.29% 81.70% +0.41%
- Complexity 152 190 +38
============================================
Files 12 13 +1
Lines 882 962 +80
Branches 115 130 +15
============================================
+ Hits 717 786 +69
- Misses 106 126 +20
+ Partials 59 50 -9 ☔ View full report in Codecov by Sentry. |
|
There seems a flaky test in workflow result: https://github.com/opensearch-project/skills/actions/runs/7456381157/job/20286930811?pr=114. |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 9, 2024
* fix compile error Signed-off-by: Hailong Cui <[email protected]> * fix compile error Signed-off-by: Hailong Cui <[email protected]> --------- Signed-off-by: Hailong Cui <[email protected]> (cherry picked from commit 7a596a0) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
xinyual
pushed a commit
that referenced
this pull request
Jan 12, 2024
* fix compile error * fix compile error --------- (cherry picked from commit 7a596a0) Signed-off-by: Hailong Cui <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
yuye-aws
pushed a commit
to yuye-aws/skills
that referenced
this pull request
Apr 26, 2024
* fix compile error * fix compile error --------- (cherry picked from commit 7a596a0) Signed-off-by: Hailong Cui <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: yuye-aws <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Two new methods add into
Tool.Factoryinterface, all implementations need implementate these two methodsIssues Resolved
new method add by this PR
https://github.com/opensearch-project/ml-commons/pull/1818/files#diff-f3f27d4e953486c2798c6edef8641779b3211dabbe5374c5bfe1737b3aab2f25
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.