Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is that we can get rid of packages folder and simplify the
bundle.js
files that were located in the packages-folder (which makes things easier to document etc) .The included
bundles/admin/admin/index.js
is an example of what the bundle.js replacement could be. In the applications main.js this would change the import from:to:
This makes everything simpler by removing lot of the copy/pasted parts of bundle.js and only leaving the essentials:
Everything else remains the same (the instance start() function is called and configuration is injected). The
bundle-loader
figures out the localization files for the bundle by searching files in theresources/locale/
folder next to the index.js. This way we only need to add the files and not reference them in the index.js. If we do need to manually setup locales, we could add something like locales.json next to index.js that can refer to files that are not in the default localization folder.