Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oskari 3.0 bundle lazy-loader #2792

Merged
merged 3 commits into from
Feb 19, 2025
Merged

Conversation

ZakarFin
Copy link
Member

@ZakarFin ZakarFin commented Feb 18, 2025

Continues: #2791 and adds oskari-lazy-bundle loader that works with the new oskari-bundle loader.

Now we have both loaders with new versions for application main.js usage:

  • oskari-bundle replaces oskari-loader and supports more streamlined bundle registrations
  • oskari-lazy-bundle replaces oskari-lazy-loader for adding support to lazy-load bundles with the streamlined bundle registration

Moved some internal'ish functions around the core (from releasenotes):

These changes shouldn't really affect your app, but things that have changed inside the "engine":

  • New core component src/BundleRegister for managing bundles and exposes Oskari.bundle() (previously part of src/loader.js) and Oskari.lazyBundle() functions.
  • Oskari.bundle_manager functions removed:
    • registerDynamic() - replaced by BundleRegister.lazyBundle() that is exposed as Oskari.lazyBundle()
    • loadDynamic() - moved to src/loader.js as private function as it doesn't need to be exposed

@ZakarFin ZakarFin marked this pull request as ready for review February 19, 2025 13:06
@ZakarFin ZakarFin added this to the 3.0.0 milestone Feb 19, 2025
@ZakarFin ZakarFin merged commit ad44d85 into oskariorg:develop Feb 19, 2025
3 checks passed
@ZakarFin ZakarFin deleted the bundle-lazy-loader branch February 19, 2025 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant