Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run app tests against latest released version #611

Closed
PVince81 opened this issue Mar 13, 2019 · 8 comments
Closed

Run app tests against latest released version #611

PVince81 opened this issue Mar 13, 2019 · 8 comments

Comments

@PVince81
Copy link
Contributor

Currently we only run app tests against stable10 to make sure they will be compatible with the future OC core platform release.

This however doesn't guarantee that the current app's core runs correctly against the last released core version.

Now I'm not sure whether we want to explode the matrix of all apps to also add the last released version.
What we could do is do so only on release branches: so whenever we plan a release (RC), we'd have tests there that don't only run against core stable10 but also against the last released version (presently 10.1.0).

Not sure how to specify said version in Drone, should we hard-code ? Or fetch it from a URL ?

@phil-davis @individual-it

cc @patrickjahns for potential additional ideas

@patrickjahns
Copy link
Contributor

Yes this definitely makes sense to be doing ( was something on my agenda for a long time ).

For this however we need to sort out how our testing harness ( that currently lives in owncloud/core ) can be backward compatible as well.

With running the smoke-test suites on our docker containers ( which are built periodically after a release to keep the underlying linux binaries up-to-date ) we've encountered issues, where tests have changed/improved ( or new test cases have been added due to a new feature ) and suddenly where failing the container builds.

currently we solve this by tagging scenarios with skipOn - and we have to be careful with setting the right tags here. Would envision that we move the skipOn logic into a skipBefore logic - where we compare the ownCloud version and then run according tests.

Something to be later defined is the part about how often these tests should run ( every PR, every night? )

Another thought:

  • what about the min-version constraint - I believe if we are able to check the latest version, we would also need to confirm that the min-version still holds true, or raise the min-version accordingly

@dpakach
Copy link
Contributor

dpakach commented Jul 3, 2019

Apps to test with latest release version

Ones to think about: (the end of the universe might come before all the tests finish ;) )

Add missing apps if any, Remove apps if these tests are not relevant on any apps.

@phil-davis
Copy link
Contributor

I updated the list to mention all apps that have acceptance tests.
If an app has acceptance tests, then they should be able to run against the latest core release.
(someone tell me why we would not do this for all these apps?)

@individual-it
Copy link
Member

apps that run all core tests, like user_ldap and encryption should only run the app-specific tests with the latest release tarball

@phil-davis
Copy link
Contributor

phil-davis commented Jul 5, 2019

core 10.2.1 has been released. New PRs for this issue can test against 10.2.1
We may as well quickly go to the apps that have already been done and s/10.2.0/10.2.1/

@paurakhsharma
Copy link
Member

paurakhsharma commented Jul 8, 2019

@phil-davis Since there are no acceptance tests in files_primary_s3.
Should we run core tests against 10.2.1 in files_primery_s3

Edit: But It will take ages to run.

@phil-davis
Copy link
Contributor

phil-davis commented Jul 8, 2019

@phil-davis Since there are no acceptance tests in files_primary_s3.
Should we run core tests against 10.2.1 in files_primery_s3

Edit: But It will take ages to run.

The same really applies to user_ldap and encryption. For any app that "plugs in a back end" to ownCloud core, we should run the core acceptance tests with the app "plugged-in" to make sure that the core behavior still works. We want to know that it works for core master, stable10 and the supported release(s).

I will raise a separate issue because for that we need to discuss how and when to run all that - #625

@skshetry
Copy link
Member

skshetry commented Jul 8, 2019

Closing this as all the apps been adjusted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

10 participants