Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

user_ldap app test against latest tarball #434

Merged
merged 1 commit into from
Jul 8, 2019

Conversation

haribhandari07
Copy link
Contributor

Description

This test guarantee that the user_ldap app runs correctly against the last released core version.

Related Issue

Part of owncloud/QA#611

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@CLAassistant
Copy link

CLAassistant commented Jul 8, 2019

CLA assistant check
All committers have signed the CLA.

@haribhandari07 haribhandari07 force-pushed the user_ldap-against-tarball branch from 932994e to ec7a6b2 Compare July 8, 2019 06:11
@codecov
Copy link

codecov bot commented Jul 8, 2019

Codecov Report

Merging #434 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #434   +/-   ##
=========================================
  Coverage     33.91%   33.91%           
  Complexity     1332     1332           
=========================================
  Files            32       32           
  Lines          3777     3777           
=========================================
  Hits           1281     1281           
  Misses         2496     2496

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72f9212...72b17cb. Read the comment docs.

@codecov
Copy link

codecov bot commented Jul 8, 2019

Codecov Report

Merging #434 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #434   +/-   ##
=========================================
  Coverage     33.91%   33.91%           
  Complexity     1332     1332           
=========================================
  Files            32       32           
  Lines          3777     3777           
=========================================
  Hits           1281     1281           
  Misses         2496     2496

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72f9212...ec7a6b2. Read the comment docs.

Copy link
Contributor

@dpakach dpakach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@haribhandari07 haribhandari07 force-pushed the user_ldap-against-tarball branch from ec7a6b2 to 72b17cb Compare July 8, 2019 09:39
@phil-davis phil-davis merged commit a4b785d into master Jul 8, 2019
@delete-merged-branch delete-merged-branch bot deleted the user_ldap-against-tarball branch July 8, 2019 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants