Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In discussion, it has been pointed out that there are more places to remove mention of PHP 5.6:
root
composer.json
of the app - bumpplatform
php
to7.0.8
and then docomposer update
to get an updatedcomposer.lock
file.vendor-bin/behat/composer.json
- bumpplatform
php
to7.0.8
-composer.lock
is not configured, so no need to touch that, it is auto-generated when tests start. This will only be in apps that have Behat acceptance testsbump the ownCloud server
min-version
inappinfo/info.xml
to10.2
- because actually we are running automated testing against the corestable10
QA tarball, which will next become10.2
. So we are not automatically sure that the app still works with core releases10.0.*
or10.1.*
(e.g. maybe some app code gets added/changed and the developer uses PHP 7.0-only syntax that does not work on PHP 5.6)Points (1) and (2) seem straightforward and "have to happen"
Point (3) could be avoided if we have a solution.process for owncloud/QA#611
which ensures that apps are tested against any older supported server versions prior to app release (and maybe every night in the automated testing)