Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove php 5.6 #718

Merged
merged 3 commits into from
Mar 13, 2019
Merged

Remove php 5.6 #718

merged 3 commits into from
Mar 13, 2019

Conversation

phil-davis
Copy link
Contributor

In discussion, it has been pointed out that there are more places to remove mention of PHP 5.6:

  1. root composer.json of the app - bump platform php to 7.0.8 and then do composer update to get an updated composer.lock file.

  2. vendor-bin/behat/composer.json - bump platform php to 7.0.8 - composer.lock is not configured, so no need to touch that, it is auto-generated when tests start. This will only be in apps that have Behat acceptance tests

  3. bump the ownCloud server min-version in appinfo/info.xml to 10.2 - because actually we are running automated testing against the core stable10 QA tarball, which will next become 10.2. So we are not automatically sure that the app still works with core releases 10.0.* or 10.1.* (e.g. maybe some app code gets added/changed and the developer uses PHP 7.0-only syntax that does not work on PHP 5.6)

Points (1) and (2) seem straightforward and "have to happen"

Point (3) could be avoided if we have a solution.process for owncloud/QA#611
which ensures that apps are tested against any older supported server versions prior to app release (and maybe every night in the automated testing)

@codecov
Copy link

codecov bot commented Mar 13, 2019

Codecov Report

Merging #718 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #718   +/-   ##
=========================================
  Coverage     83.68%   83.68%           
  Complexity      494      494           
=========================================
  Files            45       45           
  Lines          1778     1778           
=========================================
  Hits           1488     1488           
  Misses          290      290

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22c8160...ac20036. Read the comment docs.

@phil-davis phil-davis merged commit bc08708 into master Mar 13, 2019
@delete-merged-branch delete-merged-branch bot deleted the remove-php-5.6 branch March 13, 2019 14:26
@patrickjahns patrickjahns modified the milestones: development, QA Jun 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants