Add using casing check/fix for initMountPoints #26398
Conversation
|
@PVince81, thanks for your PR! By analyzing the history of the files in this pull request, we identified @DeepDiver1975, @icewind1991 and @schiessle to be potential reviewers. |
| @@ -84,6 +84,8 @@ public function getAvatar($userId) { | |||
| throw new \Exception('user does not exist'); | |||
| } | |||
|
|
|||
| $userId = $user->getUID(); | |||
There was a problem hiding this comment.
This is the only function I see with this change in this file. Is there any other function that would need this, specially the ones accepting user ids?
There was a problem hiding this comment.
Hmm, you're right. I see that getAvatarFolder is public too, so it would be safer to add the same check there.
Nice catch!
|
@jvillafanez I simply changed |
This is to make sure we don't get into user id casing issues.
PVince81
force-pushed
the
initmountpoints-userid-casing
branch
from
64252f7 to
97669c5
Compare
|
What about backwards compatibility with the previous avatar files? Is it taken into account? if not, is it worthy? I mean, the easy workaround / fix should be reupload the avatar... |
|
@jvillafanez the previous avatar files are migrated to the new format, so there is no backward compatibility needed. |
|
Looks good 👍 |
|
Tests passed, unpublished due to API rate limit => merge |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Forward port of #26271 to master.
Please review the master-specific changes in AvatarManager and AvatarManagerTest, this is because the logic changed now that the avatars are stored elsewhere. However the user casing logic must still be used here.
@jvillafanez @DeepDiver1975