Handle enable-disable of apps in acceptance tests

[phil-davis]

Description

1. In API acceptance tests, do the same as for UI acceptance tests - disable firstrunwizard and notifications apps by default. Restore previous app state at end of test run.
2. Enable notifications app for features/scenarios that require it.
3. Fixup handling of enabled/disabled apps in BeforeScenario and AfterScenario so that if a scenario changes the enabled/disabled state of apps, they will be put back on the way out.

Related Issue

Motivation and Context

The notifications app is needed for some scenarios and not for others. Enable it in the feature files when it is needed. That will allow local test runs to use whatever scenarios they like, without having to remember to enable or disable the notifications app before running the scenarios. It will also let someone run a whole set of tests in a single run (multiple suites) and the scenarios will handle whhat apps come-and-go.

How Has This Been Tested?

Local test runs starting with notifications app enabled or disabled.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Acceptance test enhancement

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

[paurakhsharma]

Everything looks good. Something is wrong with drone I guess

[phil-davis]

Yes, 1 stupid error reaching github! I restarted drone.

[phil-davis]

Backport of code in #31662

The notifications app enable changes in the feature files need to be added to the backport of notifications app testing - added commit to #31613

[phil-davis]

And now the codecov report has not come, so it will not let me merge.
Feeling very frustrated with CI time-waste today.

[codecov]

Codecov Report

Merging #31661 into master will decrease coverage by 0.8%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master   #31661      +/-   ##
============================================
- Coverage     62.87%   62.07%   -0.81%     
  Complexity    18410    18410              
============================================
  Files          1151     1151              
  Lines         69114    69105       -9     
  Branches       1260     1260              
============================================
- Hits          43456    42894     -562     
- Misses        25289    25842     +553     
  Partials        369      369

Flag	Coverage Δ	Complexity Δ
#javascript	52.39% <ø> (ø)	0 <ø> (ø)	⬇️
#phpunit	63.18% <ø> (-0.9%)	18410 <ø> (ø)

Impacted Files	Coverage Δ	Complexity Δ
lib/private/DB/OCSqlitePlatform.php	0% <0%> (-100%)	5% <0%> (ø)
lib/private/DB/PostgreSqlMigrator.php	0% <0%> (-100%)	6% <0%> (ø)
lib/private/DB/SQLiteMigrator.php	0% <0%> (-100%)	7% <0%> (ø)
lib/private/DB/SQLiteSessionInit.php	0% <0%> (-100%)	4% <0%> (ø)
...ilder/ExpressionBuilder/PgSqlExpressionBuilder.php	0% <0%> (-88.89%)	3% <0%> (ø)
lib/private/DB/AdapterOCI8.php	0% <0%> (-86.67%)	4% <0%> (ø)
lib/private/DB/AdapterPgSql.php	0% <0%> (-85.72%)	2% <0%> (ø)
lib/private/Repair/SqliteAutoincrement.php	0% <0%> (-85.19%)	9% <0%> (ø)
...Builder/ExpressionBuilder/OCIExpressionBuilder.php	0% <0%> (-85.19%)	18% <0%> (ø)
lib/private/DB/AdapterSqlite.php	0% <0%> (-83.34%)	7% <0%> (ø)
... and 22 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ebf0cb...5f5840a. Read the comment docs.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.