Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable10] Handle enable-disable of apps in acceptance tests #31662

Merged
merged 1 commit into from
Jun 6, 2018

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Jun 6, 2018

Backport #31661 part 1

This is the code part of the PR from master.
The feature/scenarios that use this code are related to notifications app testing, and have not yet been backported to stable10 - that is waiting in backport PR #31613 which I will add to.

@phil-davis phil-davis added this to the development milestone Jun 6, 2018
@phil-davis phil-davis self-assigned this Jun 6, 2018
@phil-davis phil-davis changed the title Handle enable-disable of apps in acceptance tests [stable10] Handle enable-disable of apps in acceptance tests Jun 6, 2018
@codecov
Copy link

codecov bot commented Jun 6, 2018

Codecov Report

Merging #31662 into stable10 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             stable10   #31662   +/-   ##
===========================================
  Coverage       62.13%   62.13%           
  Complexity      18241    18241           
===========================================
  Files            1195     1195           
  Lines           71743    71743           
  Branches         1248     1248           
===========================================
  Hits            44574    44574           
  Misses          26799    26799           
  Partials          370      370
Flag Coverage Δ Complexity Δ
#javascript 52.64% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 63.17% <ø> (ø) 18241 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d533834...413795a. Read the comment docs.

@phil-davis
Copy link
Contributor Author

If anyone can review this, it would be good. I want to get it into stable10 (as well as master) and be able to make use of it for the next step in fixing up the core+notifications app testing dependencies.

@phil-davis phil-davis merged commit 08a6eb5 into stable10 Jun 6, 2018
@phil-davis phil-davis deleted the stable10-notifications-enable branch June 6, 2018 15:30
@PVince81 PVince81 modified the milestones: development, QA Jun 13, 2018
@lock
Copy link

lock bot commented Jul 31, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants