Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable10] provisioning API tests for group with comma #32242

Merged
merged 2 commits into from
Aug 6, 2018

Conversation

phil-davis
Copy link
Contributor

Backport of commits from #31719 that:

  1. add acceptance test scenarios for using the Provisioning API with groups that have a comma in the group name.
  2. add unit test cases for groups that have a comma in the group name.

There are commits in that PR which modify the files:scan command to allow for group names containing a comma. Those changes are a backward-compatibility break, so are NOT backported.

@codecov
Copy link

codecov bot commented Aug 6, 2018

Codecov Report

Merging #32242 into stable10 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             stable10   #32242   +/-   ##
===========================================
  Coverage       62.73%   62.73%           
  Complexity      18721    18721           
===========================================
  Files            1220     1220           
  Lines           73391    73391           
  Branches         1279     1279           
===========================================
  Hits            46044    46044           
  Misses          26968    26968           
  Partials          379      379
Flag Coverage Δ Complexity Δ
#javascript 53.08% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 63.79% <ø> (ø) 18721 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55a730f...a95ae07. Read the comment docs.

@phil-davis phil-davis merged commit 39bd7bc into stable10 Aug 6, 2018
@phil-davis phil-davis deleted the stable10-provisioning-api-group-with-comma branch August 6, 2018 10:10
@PVince81 PVince81 modified the milestones: development, QA Sep 5, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants