Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable10] provisioning API tests for group with comma #32242

Merged
merged 2 commits into from
Aug 6, 2018
Merged

[stable10] provisioning API tests for group with comma #32242

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
44b784b
Test groups with comma in Provisioning API
phil-davis Jun 11, 2018
a95ae07
Test for groups excluded from sharing that contain comma in the group…
phil-davis Jun 19, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions tests/acceptance/features/apiProvisioning-v1/addGroup.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ So that I can more easily manage access to resources by groups rather than indiv
| group_id | comment |
| new-group | dash |
| the.group | dot |
| left,right | comma |
| España | special European characters |
| नेपाली | Unicode group name |
| 0 | The "false" group |
Expand Down
1 change: 1 addition & 0 deletions tests/acceptance/features/apiProvisioning-v1/addToGroup.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ So that I can give a user access to the resources of the group
| group_id | comment |
| new-group | dash |
| the.group | dot |
| left,right | comma |
| España | special European characters |
| नेपाली | Unicode group name |
| 0 | The "false" group |
Expand Down
1 change: 1 addition & 0 deletions tests/acceptance/features/apiProvisioning-v1/deleteGroup.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ So that I can remove unnecessary groups
| group_id | comment |
| new-group | dash |
| the.group | dot |
| left,right | comma |
| España | special European characters |
| नेपाली | Unicode group name |
| 0 | The "false" group |
Expand Down
1 change: 1 addition & 0 deletions tests/acceptance/features/apiProvisioning-v1/removeFromGroup.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ So that I can manage user access to group resources
| group_id | comment |
| new-group | dash |
| the.group | dot |
| left,right | comma |
| España | special European characters |
| नेपाली | Unicode group name |
| 0 | The "false" group |
Expand Down
1 change: 1 addition & 0 deletions tests/acceptance/features/apiProvisioning-v2/addGroup.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ So that I can more easily manage access to resources by groups rather than indiv
| group_id | comment |
| new-group | dash |
| the.group | dot |
| left,right | comma |
| España | special European characters |
| नेपाली | Unicode group name |
| 0 | The "false" group |
Expand Down
1 change: 1 addition & 0 deletions tests/acceptance/features/apiProvisioning-v2/addToGroup.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ So that I can give a user access to the resources of the group
| group_id | comment |
| new-group | dash |
| the.group | dot |
| left,right | comma |
| España | special European characters |
| नेपाली | Unicode group name |
| 0 | The "false" group |
Expand Down
1 change: 1 addition & 0 deletions tests/acceptance/features/apiProvisioning-v2/deleteGroup.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ So that I can remove unnecessary groups
| group_id | comment |
| new-group | dash |
| the.group | dot |
| left,right | comma |
| España | special European characters |
| नेपाली | Unicode group name |
| 0 | The "false" group |
Expand Down
1 change: 1 addition & 0 deletions tests/acceptance/features/apiProvisioning-v2/removeFromGroup.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ So that I can manage user access to group resources
| group_id | comment |
| new-group | dash |
| the.group | dot |
| left,right | comma |
| España | special European characters |
| नेपाली | Unicode group name |
| 0 | The "false" group |
Expand Down
9 changes: 9 additions & 0 deletions tests/lib/Share20/ManagerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1632,6 +1632,15 @@ public function dataIsSharingDisabledForUser() {
// New list only groups in common
$data[] = ['yes', \json_encode(['group1', 'group2']), null, ['group2'], true];

// New list partly in common, group names containing comma
$data[] = ['yes', \json_encode(['group1,a', 'group2']), null, ['group1,a', 'group3'], true];
$data[] = ['yes', \json_encode(['group1,a', 'group2,b']), null, ['group1,a', 'group3'], true];
$data[] = ['yes', \json_encode(['group1,a', 'group2']), null, ['group1,a', 'group3,c'], true];

// New list only groups in common, group names containing comma
$data[] = ['yes', \json_encode(['group1', 'group2,a']), null, ['group2,a'], true];
$data[] = ['yes', \json_encode(['group1,a', 'group2,a']), null, ['group2,a'], true];

return $data;
}

Expand Down