Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instance state changes asynchronously in mock API #2167

Merged
merged 2 commits into from
Apr 19, 2024

Conversation

david-crespo
Copy link
Collaborator

@david-crespo david-crespo commented Apr 19, 2024

Instead of going straight to stopped (or started, or whatever it is) instances stop at an intermediate state (stopping, starting, etc.) immediately and only hit the target state after 1 second. Instance create does creating (1s) -> starting (4s) -> running.

I've been meaning to do this for a while. It's neat because it lets us test the refresh button.

2024-04-18-instance-stopping-stopped.mp4

Copy link

vercel bot commented Apr 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
console ✅ Ready (Inspect) Visit Preview Apr 19, 2024 3:48am

Copy link
Contributor

@charliepark charliepark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@david-crespo david-crespo merged commit 06f4b86 into main Apr 19, 2024
8 checks passed
@david-crespo david-crespo deleted the mock-instance-state-timing branch April 19, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants