-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(Cross): [IOAPPX-343,IOAPPX-311] Add react-native-skia
library + Dynamic header background (under the new Experimental Lab category)
#5954
Merged
dmnplb
merged 278 commits into
master
from
IOAPPX-343-311-add-skia-add-dynamic-background-with-skia
Aug 8, 2024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 7d1beca.
Co-authored-by: Cristiano Tofani <[email protected]>
This reverts commit 413bb3f.
…T-342-react-native-upgrade
Vangaorth
approved these changes
Aug 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
dmnplb
added a commit
that referenced
this pull request
Oct 1, 2024
… + Dynamic header background (under the new Experimental Lab category) (#6123) > [!caution] > Due to the coexistence of two different versions of `XState`, this PR depends on: > * #6135 This PR restores the original PR, already approved. Read the description to learn more: * #5954 --------- Co-authored-by: Andrea <[email protected]>
dmnplb
added a commit
that referenced
this pull request
Dec 18, 2024
…tation (#5715) > [!important] > This PR depends on: > * ~#5954 **(merged and reverted)** > * #6123 ## Short description This PR adds a new card with dynamic light whose movement is based on the rotation of the device. The goal is to make light appear to reflect on the card just as it appears in the real world. The current implementation is based on the value exposed by the `useAnimatedSensor` method provided by the `reanimated` library. ## List of changes proposed in this pull request - Add the new `DSDynamicCardRotation` screen - Add relative assets ### Preview https://github.com/user-attachments/assets/943ee38a-023f-4d77-9f00-06a298cc7de0 ## How to test 1. Launch the app in a physical device (not simulator) 2. Go to the **Dynamic card based on device rotation** page and try to rotate the device --------- Co-authored-by: LazyAfternoons <[email protected]> Co-authored-by: Cristiano Tofani <[email protected]> Co-authored-by: Alice Di Rico <[email protected]> Co-authored-by: Fabio Bombardi <[email protected]> Co-authored-by: Mario Perrotta <[email protected]> Co-authored-by: LazyAfternoons <[email protected]> Co-authored-by: Andrea Piai <[email protected]> Co-authored-by: Federico Mastrini <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
code review needed 💻📱
Insert this label if you need a code review that no one in your team can give you
Cross
Design System
New visual language and reduction of previous UI clutter
Experimental lab ✨
Interface experiments that may never see the light of the day
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
This PR depends on:
Short description
This PR adds the latest version of the
react-native-skia
library and the new Experimental Lab section which includes the new Dynamic header background screen, built with theskia
libraryList of changes proposed in this pull request
react-native-skia
libraryjest
config files to includereact-native-skia
referencesPreview
dynamic-background.1.mp4
Acknowledgement
We've successfully added this library thanks to the RN upgrade to the
0.72
version:How to test