Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: [IOBP-726] Migrate IdPay machines to XState V5 #6135

Merged
merged 44 commits into from
Sep 26, 2024
Merged

chore: [IOBP-726] Migrate IdPay machines to XState V5 #6135

merged 44 commits into from
Sep 26, 2024

Conversation

mastro993
Copy link
Contributor

@mastro993 mastro993 commented Aug 30, 2024 •
edited
Loading

Short description

This PR migrates the ID Pay features which are using XState v4 to XState v5 and completely removes XState v4 from the codebase.

List of changes proposed in this pull request

  • Migrated configuration, onboarding and payment machines to xstate v5
  • Removed xstate5 and @xstate5/react
  • Refactored some ID Pay navigators to align to the rest of the ID Pay code

How to test

Static check should pass.
Test the onboarding and configuration flows of an ID Pay initiative and make sure everything works.

@pagopa-github-bot pagopa-github-bot changed the title [IOBP-726] Migrate IdPay machines to XState V5 chore: [IOBP-726] Migrate IdPay machines to XState V5 Aug 30, 2024
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Aug 30, 2024 •
edited by jira bot
Loading

Affected stories

  • ⚙️ IOBP-726: Adattare i flussi di IDPay con la versione di XState v5

Generated by 🚫 dangerJS against 1654ca7

@dmnplb dmnplb mentioned this pull request Sep 2, 2024
Merged
Hantex9
Hantex9 approved these changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@Hantex9 Hantex9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀
Tested also with the IDPay UAT env and it works fine!

@LazyAfternoons LazyAfternoons self-requested a review September 26, 2024 14:27
LazyAfternoons
LazyAfternoons approved these changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@LazyAfternoons LazyAfternoons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I couldn't find any regression in ITW.

@mastro993 mastro993 merged commit 8dbf986 into master Sep 26, 2024
13 checks passed
@mastro993 mastro993 deleted the IOBP-726-migrate-idpay-machines-to-xstate-v5 branch September 26, 2024 14:49
dmnplb added a commit that referenced this pull request Oct 1, 2024
@dmnplb @Vangaorth
chore(Cross): [IOAPPX-343,IOAPPX-311] Add react-native-skia library…
992c4c7 
… + Dynamic header background (under the new Experimental Lab category) (#6123)

> [!caution]
> Due to the coexistence of two different versions of `XState`, this PR
depends on:
> * #6135

This PR restores the original PR, already approved. Read the description
to learn more:
* #5954

---------

Co-authored-by: Andrea <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LazyAfternoons LazyAfternoons LazyAfternoons approved these changes

@Hantex9 Hantex9 Hantex9 approved these changes

@thisisjp thisisjp Awaiting requested review from thisisjp thisisjp is a code owner

Assignees

@mastro993 mastro993

Labels
IDPay keep open
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mastro993 @pagopa-github-bot @LazyAfternoons @Hantex9 @dmnplb