Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cli arg for pool lifetime #14262

Closed
mattsse opened this issue Feb 6, 2025 · 4 comments
Closed

Add cli arg for pool lifetime #14262

mattsse opened this issue Feb 6, 2025 · 4 comments
Assignees
@Cyber-Mitch
Labels
A-tx-pool Related to the transaction mempool C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started

Comments

@mattsse
Copy link
Collaborator

mattsse commented Feb 6, 2025 •
edited
Loading

Describe the feature

in #14242 we introduced a new setting for removing stale external txs after a while

we also need a CLI setting for this in:

reth/crates/node/core/src/args/txpool.rs

Line 19 in 41d51a1

pub struct TxPoolArgs {

TODO

  • add new cli duration arg

Additional context

FYI @18aaddy

No response
@mattsse mattsse added C-enhancement New feature or request S-needs-triage This issue needs to be labelled labels Feb 6, 2025
@mattsse mattsse added D-good-first-issue Nice and easy! A great choice to get started A-tx-pool Related to the transaction mempool and removed S-needs-triage This issue needs to be labelled labels Feb 6, 2025
@Cyber-Mitch
Copy link
Contributor

Hey @mattsse i want to work on this

@varun-doshi
Copy link
Contributor

I can take this up

@varun-doshi varun-doshi mentioned this issue Feb 6, 2025
Merged
@Cyber-Mitch
Copy link
Contributor

Hey @mattsse i made a PR yesterday, you haven't reviewed it

@Cyber-Mitch
Copy link
Contributor

#14286

@Cyber-Mitch Cyber-Mitch mentioned this issue Feb 8, 2025
Closed
@mattsse mattsse closed this as completed Feb 10, 2025
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Cyber-Mitch Cyber-Mitch

Labels
A-tx-pool Related to the transaction mempool C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started
Projects
Reth Tracker
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mattsse @Cyber-Mitch @varun-doshi