Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: added_cli_arg_for_pool_lifetime #14286

Closed

Conversation

Cyber-Mitch
Copy link
Contributor

Description

This PR adds a new CLI argument --txpool.max-tx-lifetime to configure the maximum lifetime of transactions in the transaction pool. The argument accepts human-readable durations (e.g., 1h, 30min, 15s), with a default value of 3h.

Changes

  • Added max_tx_lifetime field to the TxPoolArgs struct.
  • Updated the RethTransactionPoolConfig implementation to include the max_tx_lifetime field in the PoolConfig struct.
  • Added unit tests to verify the argument parsing and default value.

@mattsse

@emhane emhane added the A-cli Related to the reth CLI label Feb 8, 2025
@emhane
Copy link
Member

emhane commented Feb 8, 2025

duplicate of #14273

@Cyber-Mitch
Copy link
Contributor Author

duplicate of #14273

I was assigned this issue

@mattsse
Copy link
Collaborator

mattsse commented Feb 10, 2025

combined with #14273

@mattsse mattsse closed this Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-cli Related to the reth CLI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants