feat: Add cli arg for pool lifetime #14273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varun-doshi
requested review from
mattsse,
Rjected,
onbjerg and
klkvr
as code owners
mattsse
requested changes
Feb 6, 2025
crates/node/core/src/args/txpool.rs
Outdated
|
|
||
| /// Duration after which stale external transactions are removed. | ||
| #[arg(long = "builder.interval", value_parser = parse_duration_from_secs_or_ms, default_value = "300", value_name = "DURATION")] | ||
| pub stale_tx_timeout: Duration, |
There was a problem hiding this comment.
this should be called txpool.lifetime:
and we can use default_value_t here I think
There was a problem hiding this comment.
default_value_t requires that Duration implements the trait ToString which it doesn't
There was a problem hiding this comment.
Similar to
There was a problem hiding this comment.
right, hence the value_parse fn
varun-doshi
force-pushed
the
varun/cli-pool
branch
from
8021da5 to
55f32aa
Compare
varun-doshi
force-pushed
the
varun/cli-pool
branch
from
55f32aa to
a9f66df
Compare
|
fyi @Cyber-Mitch I integrated some of your changes here so you get listed as author |
oh okay cool |
18aaddy
pushed a commit
to 18aaddy/reth
that referenced
this pull request
Feb 12, 2025
Co-authored-by: Reentrancy <[email protected]> Co-authored-by: Reentrancy <[email protected]> Co-authored-by: Matthias Seitz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #14262