feat: refactor writing to NippyJar
#5669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit b9c51e9.
joshieDo
added
C-enhancement
joshieDo
requested review from
Rjected,
Evalir,
rakita and
onbjerg
as code owners
shekhirin
reviewed
Dec 8, 2023
Merged
Closed
onbjerg
reviewed
Dec 15, 2023
| offsets_file, | ||
| tmp_buf: Vec::with_capacity(1_000_000), | ||
| uncompressed_row_size: 0, | ||
| offsets: Vec::with_capacity(1_000_000), |
There was a problem hiding this comment.
would move these magic nums to constants just for clarity
| } | ||
|
|
||
| impl<'a, H: NippyJarHeader> NippyJarWriter<'a, H> { | ||
| pub fn new(jar: &'a mut NippyJar<H>) -> Result<Self, NippyJarError> { |
There was a problem hiding this comment.
document that this does consistency checks and self healing on open
| } | ||
|
|
||
| /// Flushes offsets to disk. | ||
| pub(crate) fn commit_offsets(&mut self) -> Result<(), NippyJarError> { |
There was a problem hiding this comment.
this should probably do sync_all to attempt to tell the OS to actually flush the data to disk and not just its i/o buffer https://doc.rust-lang.org/std/fs/struct.File.html#method.sync_all
| } | ||
|
|
||
| /// Commits configuration and offsets to disk. It drains the internal offset list. | ||
| pub fn commit(&mut self) -> Result<(), NippyJarError> { |
There was a problem hiding this comment.
any reason this does not attempt to flush data to the data file using e.g. sync_all?
Co-authored-by: Bjerg <[email protected]>
Co-authored-by: Bjerg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors
NippyJarfor compatibility with the new snapshot scope.NippyJarWriter: extracts certain logic fromNippyJarthat writes to file, refactors, and extends it. It should now be possible to create it non atomically (start, stop, continue), and prune (aka unwind) rows from the end.*.conf: contains configuration data used in consistency checks (e.g., number of rows, columns, etc.).*.off: holds the offset list with one change: the last offset now represents the expected size of the data file (used in consistency checks).*.index: PHF/Cuckoo filter-related data..conf(NippyJar) is always the last file to be written to disk. On openingNippyJarWriter, the offset list file and data file sizes are verified. If there's any discrepancy, they are truncated to match the number of rows set byNippyJar.PR on top of #5583