test(exex): introduce utils for testing #8636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shekhirin
added
C-test
shekhirin
changed the title
shekhirin
force-pushed
the
alexey/exex-testing
branch
2 times, most recently
from
34bcb98 to
68c1d42
Compare
shekhirin
force-pushed
the
alexey/exex-testing
branch
from
68c1d42 to
b21619e
Compare
mattsse
requested changes
Jun 6, 2024
crates/exex-test-utils/src/lib.rs
Outdated
Comment on lines
117
to
123
| type TmpDB = Arc<TempDatabase<DatabaseEnv>>; | ||
| type Adapter = NodeAdapter< | ||
| RethFullAdapter<TmpDB, TestNode>, | ||
| <<TestNode as Node<FullNodeTypesAdapter<TestNode, TmpDB, BlockchainProvider<TmpDB>>>>::ComponentsBuilder as NodeComponentsBuilder< | ||
| RethFullAdapter<TmpDB, TestNode>, | ||
| >>::Components, | ||
| >; |
There was a problem hiding this comment.
we should do smth about this,
not loving how this looks -.-
There was a problem hiding this comment.
took me a while to get all the types right :D
examples/exex/minimal/src/main.rs
Outdated
Comment on lines
66
to
67
| let TestExExContext { ctx, genesis, provider_factory: _, mut events_rx, notifications_tx } = | ||
| test_exex_context().await?; |
There was a problem hiding this comment.
I think we want a wrapper type for anything besides the ctx so that we add helper functions, like emit chain committed and assert functions for receiving etc
| use reth_exex::{ExExEvent, ExExNotification}; | ||
| use reth_exex_test_utils::{test_exex_context, PollOnce, TestExExContext}; | ||
|
|
||
| #[tokio::test] |
There was a problem hiding this comment.
this should likely use multi-thread flavor
There was a problem hiding this comment.
unsure, why? we're not running the node
shekhirin
force-pushed
the
alexey/exex-testing
branch
from
6d86c4d to
262d637
Compare
mattsse
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8545
This requires a separate crate and not just a
test-utilsfeature for thereth-exexcrate, because we depend onreth-node-builderwhich in turn depends onreth-exex, creating a circular dependency.The next step is to give out to the caller the control over
TestPooland other dependencies that may want to be mocked for testing purposes.