Ability to ignore modules at least in well-known environments #474

gimenete · 2018-01-02T20:19:35Z

This is a 🙋 feature request.

I was trying to use parcel.js for an electron application. The goal is to have a lightweight HMR solution without the need to set up something complex. Besides I love the fine grained control you can get with module.hot.dispose and module.hot.accept.

parcel index.html

🤔 Expected Behavior

parcel.js should not bundle the electron package.

😯 Current Behavior

🚨  /Users/gimenete/projects/unicycle/unicycle/node_modules/electron/index.js: Could not statically evaluate fs call

Basically parcel is trying to bundle the electron package itself. Internally electron does things with the file system. I cannot control that, but even more: there's no need to bundle electron itself with the code.

💁 Possible Solution

I like the idea of having well-known environment configurations, such as eslint does. So we could have:

parcel --env electron index.html

This would apply some additional rules to parcel due to the selected environment. For example ignoring electron or even ignoring all node_modules.

💻 Code Sample

As soon as you import electron itself:

<!DOCTYPE html>
<html>

<head>
  <meta charset="UTF-8">
</head>

<body>
  <script>
    window.nodeRequire = require;
    delete window.require;
    delete window.exports;
    delete window.module;
  </script>
  <script src="./hello.js"></script>
</body>

</html>

// hello.js
import * as electron from "electron";

console.log('hello world');

The build fails. The additional <script> with those deletes is due to this: #321 Which is another thing the --env idea could fix.

🌍 Your Environment

Software	Version(s)
Parcel	1.4.1
Node	v8.9.1
npm/Yarn	npm 5.5.1
Operating System	macOS High Sierra

The text was updated successfully, but these errors were encountered:

gimenete · 2018-01-03T09:19:02Z

I've created a repo to reproduce the problem: https://github.com/gimenete/electron-parcel-bug-report

bardiarastin · 2018-01-24T07:59:24Z

any news on this ? unable to use parcel in electron environments :(

astra137 · 2018-01-24T10:17:16Z

I toyed around with this by skipping in dependencies.js anything that looked like packages. I'm guessing Parcel's previous require stuff would get stuff loaded, but I'm still studying how things get added to bundles. I'm going to keep throwing myself at it for a bit.

morajabi · 2018-01-26T19:10:48Z

I'm using it in an Electron app, can anyone guide me either how to fix this in a PR or suggest a workaround? I'd happily do a PR.

morajabi · 2018-01-26T20:01:16Z

OK, it seems a workaround can be something like this, so Parcel won't bundle it.

<html>

<head>
  <meta name="viewport" content="width=device-width, initial-scale=1">
  <script>
    window.nodeRequire = require;
    delete window.require;
    delete window.exports;
    delete window.module;
    const electron = nodeRequire('electron');
  </script>
</head>

<body>
  <div id="root"></div>
  <script src="./index.js"></script>
</body>

</html>

Or another solution is, if you need it in the renderer js entry file (which is bundled with Parcel), you can require it like this:

// renderer.js
const electron = eval(`require('electron')`) /* or nodeRequire if you changed it */

By using eval parcel won't bundle this, but in the runtime, it'll be loaded normally.

astra137 · 2018-01-26T22:42:50Z

Per the guidance of @devongovett in #448, I added a simple and dumb check to Resolver.js to return null if the filename started with . or / and it worked. I had to add some null handlers in Bundler.js, but it was working for my Vue powered Electron app.

However, because require exists while the bundle is loading, it is saved at module.bundle.parent and exposed that way to the HMR module. Plugins can override the builtins, like parcel-plugin-vue does, which ensures that the check for parent happens. Hot loading cannot be enabled without also sending a pull request off to each plugin that happens to override the altered HMR builtin.

I don't know if I have exhausted all of the options, but I think parcel would need to disallow plugins from altering built-in packagers for this feature to be stable.

morajabi · 2018-01-28T09:35:53Z

@maccelerated I think the solution above I posted is simpler, no?

astra137 · 2018-01-28T10:31:21Z

I was trying to prevent Parcel from bundling any package, but yeah, escaping electron like that would get you up and running.

gimenete · 2018-01-28T12:34:28Z

escaping electron like that should be only a quick workaround. But doesn't work in all scenarios. For example if you are transpiling from typescript, you don't have much control over how typescript generates the require() calls.

astra137 · 2018-01-28T23:01:54Z

Just throwing a reference in to #192 node bundling mode and its PR #652, which seems to be a HMR-less solution.

see: parcel-bundler/parcel#474

lbguilherme · 2018-01-31T15:21:36Z

@maccelerated and others: modified PR #652 for electron support. Please check if it's ok for your usecase.

DeMoorJasper added 🙋‍♀️ Feature 💬 RFC Request For Comments 🙏 Help Wanted labels Jan 2, 2018

devongovett mentioned this issue Jan 3, 2018

[WIP/RFC] .parcelignore #448

Closed

3 tasks

fathyb mentioned this issue Jan 9, 2018

Use browser-resolve to ignore fs inlining #523

Merged

gimenete mentioned this issue Jan 29, 2018

Add "--target=node" option to produce a NodeJS-friendly bundle, and also "--target=electron" #652

Merged

Sanster pushed a commit to Sanster/AnyLabel that referenced this issue Jan 30, 2018

use tricky method to open dialog in renderjs

f1c6508

see: parcel-bundler/parcel#474

devongovett closed this as completed in #652 Feb 5, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ability to ignore modules at least in well-known environments #474

Ability to ignore modules at least in well-known environments #474

gimenete commented Jan 2, 2018

gimenete commented Jan 3, 2018

bardiarastin commented Jan 24, 2018

astra137 commented Jan 24, 2018

morajabi commented Jan 26, 2018

morajabi commented Jan 26, 2018 •

edited

Loading

astra137 commented Jan 26, 2018 •

edited

Loading

morajabi commented Jan 28, 2018

astra137 commented Jan 28, 2018

gimenete commented Jan 28, 2018

astra137 commented Jan 28, 2018

lbguilherme commented Jan 31, 2018

Ability to ignore modules at least in well-known environments #474

Ability to ignore modules at least in well-known environments #474

Comments

gimenete commented Jan 2, 2018

🤔 Expected Behavior

😯 Current Behavior

💁 Possible Solution

💻 Code Sample

🌍 Your Environment

gimenete commented Jan 3, 2018

bardiarastin commented Jan 24, 2018

astra137 commented Jan 24, 2018

morajabi commented Jan 26, 2018

morajabi commented Jan 26, 2018 • edited Loading

astra137 commented Jan 26, 2018 • edited Loading

morajabi commented Jan 28, 2018

astra137 commented Jan 28, 2018

gimenete commented Jan 28, 2018

astra137 commented Jan 28, 2018

lbguilherme commented Jan 31, 2018

morajabi commented Jan 26, 2018 •

edited

Loading

astra137 commented Jan 26, 2018 •

edited

Loading